From: Eric Blake <eblake@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs
Date: Fri, 20 Jun 2014 09:34:37 -0600 [thread overview]
Message-ID: <53A4548D.5030306@redhat.com> (raw)
In-Reply-To: <62b39b7df103a398e83481a4fc169def1ab4299b.1403243169.git.hutao@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On 06/19/2014 11:55 PM, Hu Tao wrote:
> "0x1-0x10" looks better than "0x1-10"
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
> qapi/string-output-visitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c
> index e9aca3b..1ab8574 100644
> --- a/qapi/string-output-visitor.c
> +++ b/qapi/string-output-visitor.c
> @@ -98,7 +98,7 @@ static void format_string(StringOutputVisitor *sov, Range *r, bool next,
> {
> if (r->end - r->begin > 1) {
> if (human) {
> - g_string_append_printf(sov->string, "0x%" PRIx64 "-%" PRIx64,
> + g_string_append_printf(sov->string, "0x%" PRIx64 "-0x%" PRIx64,
> r->begin, r->end - 1);
>
> } else {
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-20 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 5:55 [Qemu-devel] [PATCH 0/3] another round of pci fixes Hu Tao
2014-06-20 5:55 ` [Qemu-devel] [PATCH 1/3] fixup! libqemustub: add more stubs for qemu-char Hu Tao
2014-06-20 6:03 ` Nikolay Nikolaev
2014-06-20 6:17 ` Hu Tao
2014-06-20 6:31 ` [Qemu-devel] [PATCH v2] " Hu Tao
2014-06-20 8:26 ` [Qemu-devel] [PATCH 1/3] " Peter Maydell
2014-06-20 8:29 ` Hu Tao
2014-06-20 5:55 ` [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs Hu Tao
2014-06-20 15:34 ` Eric Blake [this message]
2014-06-20 5:55 ` [Qemu-devel] [PATCH 3/3] tests: add human format test for string output visitor Hu Tao
2014-06-20 15:40 ` Eric Blake
2014-06-22 10:11 ` Michael S. Tsirkin
2014-06-22 7:19 ` [Qemu-devel] [PATCH 0/3] another round of pci fixes Michael S. Tsirkin
2014-06-29 15:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A4548D.5030306@redhat.com \
--to=eblake@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).