From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wy0q9-0002ir-7y for qemu-devel@nongnu.org; Fri, 20 Jun 2014 11:35:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wy0q3-0003vT-2v for qemu-devel@nongnu.org; Fri, 20 Jun 2014 11:34:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wy0q2-0003vC-QU for qemu-devel@nongnu.org; Fri, 20 Jun 2014 11:34:51 -0400 Message-ID: <53A4548D.5030306@redhat.com> Date: Fri, 20 Jun 2014 09:34:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <62b39b7df103a398e83481a4fc169def1ab4299b.1403243169.git.hutao@cn.fujitsu.com> In-Reply-To: <62b39b7df103a398e83481a4fc169def1ab4299b.1403243169.git.hutao@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cmnE9boJU0sNPeWf9Nwwl0riR0vU68B6c" Subject: Re: [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , qemu-devel@nongnu.org Cc: Yasunori Goto , "Michael S. Tsirkin" , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cmnE9boJU0sNPeWf9Nwwl0riR0vU68B6c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2014 11:55 PM, Hu Tao wrote: > "0x1-0x10" looks better than "0x1-10" >=20 > Signed-off-by: Hu Tao > --- > qapi/string-output-visitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.= c > index e9aca3b..1ab8574 100644 > --- a/qapi/string-output-visitor.c > +++ b/qapi/string-output-visitor.c > @@ -98,7 +98,7 @@ static void format_string(StringOutputVisitor *sov, R= ange *r, bool next, > { > if (r->end - r->begin > 1) { > if (human) { > - g_string_append_printf(sov->string, "0x%" PRIx64 "-%" PRIx= 64, > + g_string_append_printf(sov->string, "0x%" PRIx64 "-0x%" PR= Ix64, > r->begin, r->end - 1); > =20 > } else { >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cmnE9boJU0sNPeWf9Nwwl0riR0vU68B6c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTpFSNAAoJEKeha0olJ0Nq+yMH/2RT6Wn6EqxzAPHOWthXpVur LWTZQHJFn6c0+a7IoIiFGptjiEXyjuZt00KZ9VzZp+Zgq8xETnuvksTGAkkzKixq 6NKthz9Fr2EH7KGFB+U3jlM6YhTVBkCGn+l7jSXIT263nAeO6C7/mnRqgq/G47Dw mCSSuM4hChQIJiCLMGoqYmd32itUAl8g9qkGkWbzIxtMcfLyJz7MkdsRKb6r9vNF MUV6lXid+w6Is2VUnDiBYB/yiHrDfyoG7yMMHGHRztiaj5C/tqcBlNPJf4OGQ8OP l94qvgw9tMB+afaWoyn3fGXfpfcxTIONuDdN+y1fe+j4qO352gfngIx7vEUFTbA= =CeqU -----END PGP SIGNATURE----- --cmnE9boJU0sNPeWf9Nwwl0riR0vU68B6c--