From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wy11S-0006p1-5A for qemu-devel@nongnu.org; Fri, 20 Jun 2014 11:46:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wy11M-0000iw-BC for qemu-devel@nongnu.org; Fri, 20 Jun 2014 11:46:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wy11L-0000il-SB for qemu-devel@nongnu.org; Fri, 20 Jun 2014 11:46:32 -0400 Message-ID: <53A45753.6090505@redhat.com> Date: Fri, 20 Jun 2014 09:46:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403253206-11133-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1403253206-11133-1-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KvcJhCC7spXkSQk1k9JHwVoWHrNUtFodD" Subject: Re: [Qemu-devel] [PATCH v3] qmp: add ACPI_DEVICE_OST event handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: wenchaoqemu@gmail.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KvcJhCC7spXkSQk1k9JHwVoWHrNUtFodD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/20/2014 02:33 AM, Igor Mammedov wrote: > emits event when ACPI OSPM evaluates _OST method > of ACPI device. >=20 > Signed-off-by: Igor Mammedov > --- > v2: > - use new QAPI event infrastructure > from rebased PCI tree on top of today's QMP pull request > --- > hw/acpi/memory_hotplug.c | 7 ++++++- > qapi-event.json | 10 ++++++++++ > 2 files changed, 16 insertions(+), 1 deletions(-) >=20 > +++ b/qapi-event.json > @@ -304,3 +304,13 @@ > { 'event': 'QUORUM_REPORT_BAD', > 'data': { '*error': 'str', 'node-name': 'str', > 'sector-num': 'int', 'sector-count': 'int' } } > + > +## > +# @ACPI_DEVICE_OST > +# > +# Emitted when guest executes ACPI _OST method. > +# > +# @info: ACPIOSTInfo type as described in qapi-schema.json Needs 'Since: 2.1'. > +## > +{ 'event': 'ACPI_DEVICE_OST', > + 'data': { 'info': 'ACPIOSTInfo' } } >=20 Not your fault, as the problem already exists, but it's a bit awkward that qapi-event.json is not self-contained, and your patch is only making it worse. qapi-event.json only makes sense when included by qapi-schema.json, when ideally it would be nice if it made sense if compiled in isolation. I already pointed this fact out on Wenchao's series that made events part of QAPI, but fixing it first requires teaching the code generators to flag places where a type is used without a pre-definition, so that we know which types have to be moved into a common include. So don't let this comment hold up your patch. If you add the Since line, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KvcJhCC7spXkSQk1k9JHwVoWHrNUtFodD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTpFdTAAoJEKeha0olJ0NqZ8AH/Ryq0oUAMYzVFw6xkcCeliSz rO4Uq2qy7vfkg67wWrPwQFj9RHL5OPYX3AMdH6G2MXezn4MObaTfgQVzrPbczv0T 2k4P2iD18WtOMnmP1JONxciHdNiDTCXTapDeqcaU0AD94t3D4t7giO5XjeinOOSK ++IhsycKE1HEJTqf+NW02bdYK1xNS+HQzw7M/Xzb7aIc4A4U2bOWWmSBl+apK5IZ Itg9NzYpukCKbJf5TaXARJjcmuouDvXIsHxZRt3iThhpcrQc3BiN+hzuRzuukG8E uwtinPu/L/4vZd8Q3ju/GuHggXjBSdTyMaCIyUY5/ny/0sCb2nJ9L55N/65/Z6U= =Fpsq -----END PGP SIGNATURE----- --KvcJhCC7spXkSQk1k9JHwVoWHrNUtFodD--