From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60630)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Wy2Es-0005ik-4W
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 13:04:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Wy2Ek-0006yT-Kz
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 13:04:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Wy2Ek-0006xM-Cf
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 13:04:26 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5KH4NvQ011699
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 20 Jun 2014 13:04:23 -0400
Message-ID: <53A46993.4030609@redhat.com>
Date: Fri, 20 Jun 2014 19:04:19 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1403118403-14397-1-git-send-email-mreitz@redhat.com>
	<1403118403-14397-2-git-send-email-mreitz@redhat.com>
	<53A2A2D4.8040104@redhat.com>
In-Reply-To: <53A2A2D4.8040104@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 19.06.2014 10:44, Paolo Bonzini wrote:
> Il 18/06/2014 21:06, Max Reitz ha scritto:
>> +static void nbd_set_handlers(NBDClient *client)
>> +{
>> +    if (client->exp && client->exp->ctx) {
>> +        aio_set_fd_handler(client->exp->ctx, client->sock,
>> +                           client->can_read ? nbd_read : NULL,
>> +                           client->send_coroutine ? 
>> nbd_restart_write : NULL,
>> +                           client);
>> +    }
>> +}
>
>
> Note that aio_set_fd_handler doesn't exist on Windows (yet), so this 
> patch breaks compilation on Windows.  We can fix this for 2.2 and then 
> apply your patches.

Okay, I'll add "for 2.2" to the subject and a comment to the cover 
letter for v3.

Max