[Qemu-devel] [PATCH-trivial] Grub fails to boot from internal TFTP server when loading more than 3 initrd files.

[Qemu-devel] [PATCH-trivial] Grub fails to boot from internal TFTP server when loading more than 3 initrd files.

[Bernhard Übelacker]

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

- From a5c3977f133faa8d7e403005325014f114234307 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bernhard=20=C3=9Cbelacker?= <bernhardu@vr-web.de>
Date: Sat, 21 Jun 2014 15:26:05 +0200
Subject: Increase maximum number of session of the internal TFTP server.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Grub fails to boot from internal TFTP server when loading more than 3 initrd files.

Grub first opens a session to the TFTP server for every initrd file and
retrieves only the file size for all.
Then it wants to download the content using the old sessions which are
already expired.

Increasing the maximum number of session of the internal TFTP
server avoids this issue.

The error message reads as following:
error: timeout reading
`/boot/ISO.ROOT/BOOTMGR'.

Press any key to continue...

Signed-off-by: Bernhard Übelacker <bernhardu@vr-web.de>
- ---
 slirp/tftp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/slirp/tftp.h b/slirp/tftp.h
index 87adeb5..e1cc24b 100644
- --- a/slirp/tftp.h
+++ b/slirp/tftp.h
@@ -2,7 +2,7 @@
 #ifndef SLIRP_TFTP_H
 #define SLIRP_TFTP_H 1
 
- -#define TFTP_SESSIONS_MAX 3
+#define TFTP_SESSIONS_MAX 20
 
 #define TFTP_SERVER	69
 
- -- 
2.0.0

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTpYhaAAoJEOlvol+DpkHmm7gH/RLFNo4Xmkyj160C9lmOs9t3
rsAoyk0RA3ao+36xQZKBZ9yIuvRdVh3vHSIROpMm88ZP/0ZFOqDbU+rLMKkZNHTz
E0iNk+zqco64yp2Ar7dtGnyLHcH4H9Xwc4w6herPYj4sU4NDl3OAIZdF5+h+0HVk
JgiR+ZtLrGMBamAzF36rnc8n8SWnLszV2CvkvVoBjzCqs9Ix+Bx2oByTkqBC6W9J
k9byJn72O4PrBzEXdBc4NgOoHQLyEWQd55sYobowignvXhMvH5fQNsnXDZEXl5vB
GmctMesy5kymSf+0qwElx8eNGyF8suGRwhQKppxEcqsC+WaR3AUGjzXCPGXvjp4=
=CY5R
-----END PGP SIGNATURE-----

[-- Attachment #2: 0001-Increase-maximum-number-of-session-of-the-internal-T.patch --]
[-- Type: text/x-patch, Size: 1277 bytes --]

>From a5c3977f133faa8d7e403005325014f114234307 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bernhard=20=C3=9Cbelacker?= <bernhardu@vr-web.de>
Date: Sat, 21 Jun 2014 15:26:05 +0200
Subject: Increase maximum number of session of the internal TFTP server.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Grub fails to boot from internal TFTP server when loading more than 3 initrd files.

Grub first opens a session to the TFTP server for every initrd file and
retrieves only the file size for all.
Then it wants to download the content using the old sessions which are
already expired.

Increasing the maximum number of session of the internal TFTP
server avoids this issue.

The error message reads as following:
error: timeout reading
`/boot/ISO.ROOT/BOOTMGR'.

Press any key to continue...

Signed-off-by: Bernhard Ãœbelacker <bernhardu@vr-web.de>
---
 slirp/tftp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/slirp/tftp.h b/slirp/tftp.h
index 87adeb5..e1cc24b 100644
--- a/slirp/tftp.h
+++ b/slirp/tftp.h
@@ -2,7 +2,7 @@
 #ifndef SLIRP_TFTP_H
 #define SLIRP_TFTP_H 1
 
-#define TFTP_SESSIONS_MAX 3
+#define TFTP_SESSIONS_MAX 20
 
 #define TFTP_SERVER	69
 
-- 
2.0.0


[-- Attachment #3: 0001-Increase-maximum-number-of-session-of-the-internal-T.patch.sig --]
[-- Type: application/pgp-signature, Size: 287 bytes --]

Re: [Qemu-devel] [Qemu-trivial] [PATCH-trivial] Grub fails to boot from internal TFTP server when loading more than 3 initrd files.

[Michael Tokarev]

21.06.2014 17:28, Bernhard Übelacker wrote:
> - From a5c3977f133faa8d7e403005325014f114234307 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Bernhard=20=C3=9Cbelacker?= <bernhardu@vr-web.de>
> Date: Sat, 21 Jun 2014 15:26:05 +0200
> Subject: Increase maximum number of session of the internal TFTP server.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Grub fails to boot from internal TFTP server when loading more than 3 initrd files.
> 
> Grub first opens a session to the TFTP server for every initrd file and
> retrieves only the file size for all.
> Then it wants to download the content using the old sessions which are
> already expired.
> 
> Increasing the maximum number of session of the internal TFTP
> server avoids this issue.

This looks sane.  And while slirp has the maintainer, he appears to be
inactive, so applying it to -trivial.  Thank you!

/mjt