From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34316)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <antivano@cisco.com>) id 1Wz2wB-0008VD-MY
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 08:01:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <antivano@cisco.com>) id 1Wz2w5-0002Fd-TY
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 08:01:27 -0400
Received: from rcdn-iport-5.cisco.com ([173.37.86.76]:27594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <antivano@cisco.com>) id 1Wz2w5-0002FI-NP
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 08:01:21 -0400
From: "Anton Ivanov (antivano)" <antivano@cisco.com>
Date: Mon, 23 Jun 2014 12:01:19 +0000
Message-ID: <53A8170D.4040006@cisco.com>
References: <1403256881-47264-1-git-send-email-anton.ivanov@kot-begemot.co.uk>
	<20140623115017.GB15351@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140623115017.GB15351@stefanha-thinkpad.redhat.com>
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <4E6E6E491FBB734686980376AF3B8D3A@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v9] net: L2TPv3 transport
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, "anton.ivanov@kot-begemot.co.uk" <anton.ivanov@kot-begemot.co.uk>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "stefanha@redhat.com" <stefanha@redhat.com>

On 23/06/14 12:50, Stefan Hajnoczi wrote:
> On Fri, Jun 20, 2014 at 10:34:41AM +0100, anton.ivanov@kot-begemot.co.uk =
wrote:
>> From: Anton Ivanov <antivano@cisco.com>
>>
>> This transport allows to connect a QEMU nic to a static Ethernet
>> over L2TPv3 tunnel. The transport supports all options present
>> in the Linux kernel implementation. It allows QEMU to connect
>> to any Linux host running kernel 3.3+, most routers and network
>> devices as well as other QEMU instances.
>>
>> Signed-off-by: Anton Ivanov <antivano@cisco.com>
>> ---
>>
>> Comments addressed in this patch:
>>
>> 1. Extra checks and reinitilization of the result variable in init to
>> address remaining potential failure cases in getaddrinfo() as noticed=20
>> by Stefan Hajnoczi
>>
>>  net/Makefile.objs |    1 +
>>  net/clients.h     |    2 +
>>  net/l2tpv3.c      |  757 ++++++++++++++++++++++++++++++++++++++++++++++=
+++++++
>>  net/net.c         |    3 +
>>  qapi-schema.json  |   60 +++++
>>  qemu-options.hx   |   82 ++++++
>>  6 files changed, 905 insertions(+)
>>  create mode 100644 net/l2tpv3.c
> Thanks, applied to my net tree:
> https://github.com/stefanha/qemu/commits/net
>
> Note I had to add the following to make -netdev work:
> @@ -842,6 +845,9 @@ static int net_client_init1(const void *object, int i=
s_netdev, Error **errp)
>  #ifdef CONFIG_VHOST_NET_USED
>          case NET_CLIENT_OPTIONS_KIND_VHOST_USER:
>  #endif
> +#ifdef CONFIG_LINUX
> +        case NET_CLIENT_OPTIONS_KIND_L2TPV3:
> +#endif
>              break;
> =20
>          default:
>
> Stefan
I will pull that.

Thanks,

A.=