* [Qemu-devel] [PATCH] target-s390x: Remove unused ld_code6() function
@ 2014-06-23 23:06 Peter Maydell
2014-06-24 4:17 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2014-06-23 23:06 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Alexander Graf, Richard Henderson
The ld_code6() function is unused; remove it.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
We could use this for loads of 6-byte insns, but that would
imply a pointless reload of the first 2 bytes, which is
presumably why this function isn't actually used.
---
target-s390x/translate.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/target-s390x/translate.c b/target-s390x/translate.c
index 8ca4824..e2a1d05 100644
--- a/target-s390x/translate.c
+++ b/target-s390x/translate.c
@@ -264,11 +264,6 @@ static inline uint64_t ld_code4(CPUS390XState *env, uint64_t pc)
return (uint64_t)(uint32_t)cpu_ldl_code(env, pc);
}
-static inline uint64_t ld_code6(CPUS390XState *env, uint64_t pc)
-{
- return (ld_code2(env, pc) << 32) | ld_code4(env, pc + 2);
-}
-
static int get_mem_index(DisasContext *s)
{
switch (s->tb->flags & FLAG_MASK_ASC) {
--
2.0.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-s390x: Remove unused ld_code6() function
2014-06-23 23:06 [Qemu-devel] [PATCH] target-s390x: Remove unused ld_code6() function Peter Maydell
@ 2014-06-24 4:17 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2014-06-24 4:17 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: qemu-trivial, Alexander Graf
On 06/23/2014 04:06 PM, Peter Maydell wrote:
> The ld_code6() function is unused; remove it.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> We could use this for loads of 6-byte insns, but that would
> imply a pointless reload of the first 2 bytes, which is
> presumably why this function isn't actually used.
Exactly so.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-24 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-23 23:06 [Qemu-devel] [PATCH] target-s390x: Remove unused ld_code6() function Peter Maydell
2014-06-24 4:17 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).