From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Subject: Re: [Qemu-devel] [PATCH 0/3] target-sparc: fixed unused function warnings
Date: Mon, 23 Jun 2014 21:24:30 -0700 [thread overview]
Message-ID: <53A8FD7E.40107@twiddle.net> (raw)
In-Reply-To: <1403564491-15624-1-git-send-email-peter.maydell@linaro.org>
On 06/23/2014 04:01 PM, Peter Maydell wrote:
> These patchsets fix clang 3.4 warnings about unused static inline
> functions (clang now warns about these if they're defined in a
> .c file but then not used; gcc doesn't). The first patch just
> removes two totally unused functions; the second two patches
> use ifdeffery to avoid defining the functions in non-TARGET_SPARC64
> builds.
I think I would be happier if you changed the functions to not be marked as
"inline". I think that there's a large body of code that marks things inline
exactly to prevent unused warnings with gcc. If we're going to play with the
ifdeffery, we might as well just let any compiler warn if its unused.
r~
next prev parent reply other threads:[~2014-06-24 4:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 23:01 [Qemu-devel] [PATCH 0/3] target-sparc: fixed unused function warnings Peter Maydell
2014-06-23 23:01 ` Peter Maydell
2014-06-23 23:01 ` [Qemu-devel] [PATCH 1/3] target-sparc: Remove unused gen_op_subi_cc and gen_op_addi_cc Peter Maydell
2014-06-23 23:01 ` [Qemu-devel] [PATCH 2/3] target-sparc: address_mask(), asi_address_mask() are TARGET_SPARC64 only Peter Maydell
2014-06-23 23:01 ` [Qemu-devel] [PATCH 3/3] target-sparc: is_translating_asi() is " Peter Maydell
2014-06-24 4:24 ` Richard Henderson [this message]
2014-06-24 8:33 ` [Qemu-devel] [PATCH 0/3] target-sparc: fixed unused function warnings Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A8FD7E.40107@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).