From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzIHk-0005Wd-6V for qemu-devel@nongnu.org; Tue, 24 Jun 2014 00:24:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzIHb-0002ls-2M for qemu-devel@nongnu.org; Tue, 24 Jun 2014 00:24:44 -0400 Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:52248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzIHa-0002ln-Te for qemu-devel@nongnu.org; Tue, 24 Jun 2014 00:24:34 -0400 Received: by mail-qc0-f175.google.com with SMTP id i8so7004402qcq.34 for ; Mon, 23 Jun 2014 21:24:34 -0700 (PDT) Sender: Richard Henderson Message-ID: <53A8FD7E.40107@twiddle.net> Date: Mon, 23 Jun 2014 21:24:30 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1403564491-15624-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1403564491-15624-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] target-sparc: fixed unused function warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Blue Swirl , Mark Cave-Ayland On 06/23/2014 04:01 PM, Peter Maydell wrote: > These patchsets fix clang 3.4 warnings about unused static inline > functions (clang now warns about these if they're defined in a > .c file but then not used; gcc doesn't). The first patch just > removes two totally unused functions; the second two patches > use ifdeffery to avoid defining the functions in non-TARGET_SPARC64 > builds. I think I would be happier if you changed the functions to not be marked as "inline". I think that there's a large body of code that marks things inline exactly to prevent unused warnings with gcc. If we're going to play with the ifdeffery, we might as well just let any compiler warn if its unused. r~