From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzRq1-0006Hi-QW for qemu-devel@nongnu.org; Tue, 24 Jun 2014 10:36:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzRpv-0003xY-3D for qemu-devel@nongnu.org; Tue, 24 Jun 2014 10:36:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzRpu-0003wl-Rb for qemu-devel@nongnu.org; Tue, 24 Jun 2014 10:36:39 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5OEabKI008987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 24 Jun 2014 10:36:37 -0400 Message-ID: <53A98CF4.9090302@redhat.com> Date: Tue, 24 Jun 2014 08:36:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401392201-29988-1-git-send-email-lersek@redhat.com> <1401392201-29988-3-git-send-email-lersek@redhat.com> <538794A9.1000906@redhat.com> <53879BDB.8050403@redhat.com> <5387A118.5090304@redhat.com> <53A98967.3030003@redhat.com> In-Reply-To: <53A98967.3030003@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tj0VjRR6QdMEboSBAlmbHXnEtsGqWX1TR" Subject: Re: [Qemu-devel] [PATCH 2/2] char: report frontend open/closed state in 'query-chardev' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tj0VjRR6QdMEboSBAlmbHXnEtsGqWX1TR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable [cc'ing Luiz] On 06/24/2014 08:21 AM, Laszlo Ersek wrote: > On 05/29/14 23:05, Eric Blake wrote: >> On 05/29/2014 02:43 PM, Laszlo Ersek wrote: >>> In this series I try to implement the ideas that (I believe) were >>> suggested by Gerd and Amit in >>> . >>>=20 >>> When the guest agent exits or dies (disconnects from the virtio-seria= l >>> port), the backend (eg. a host-side unix domain socket) doesn't (in >>> general, can't) reflect it. This lack of info tends to trip up libvir= t >>> in some cases, waiting indefinitely for an agent that doesn't exist. >>>=20 >>> The series adds two monitor events that report about virtio-serial po= rts >>> being opened and closed (for online notification), and extends the >>> "query-chardev" QMP command's return type with a "frontend_open" bool= >>> (for querying at late libvirt startup). >> >>>>> +# backend (eg. with the chardev=3D... option) is i= n open or >>>>> +# closed state (since 2.2) >>>> >>>> Why 2.2? Are you saying it is too late to make the 2.1 soft freeze? >>> >>> I thought that reviewers would immediately question the direction of = the >>> patchset (ie. monitor events + new query field), and not just suggest= >>> tweaks; so 2.2 seemed safer. Perhaps I can make it till the 2.1 soft >>> freeze (June 17th), but that depends (as I've learned now) on Wenchao= 's >>> series too. >> >> Actually, I think your series and Wenchao's are mostly orthogonal - >> either could go in first, and it's just fine if one hits 2.1 while the= >> other waits till 2.2. It's just a matter of code churn, where getting= >> both in means whoever is second has to consider the code added in the >> meantime (either your series is tweaked to use the qapi generation, or= >> Wenchao's series is tweaked to convert "one" more event). >=20 > I'm thinking about resuming work on this. Wenchao's series has been > applied (ends at commit 75175173). We're between soft and hard freeze > now. Should I aim at 2.1 or 2.2? This series was posted before soft freeze, but adds a new feature. If we're going to get it in the 2.1 release, it must be before hard freeze. I'll leave it up to Luiz whether a QMP addition this late in the game is safe to take, although my personal opinion is that since it was proposed before soft freeze, and DOES make life easier for libvirt, it is worth a strong consideration. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tj0VjRR6QdMEboSBAlmbHXnEtsGqWX1TR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTqYz0AAoJEKeha0olJ0NqxbMH/0CRbkF77M+prArjJFgF56mp 0Cm6zssZcMYtiqpt3ezN1JWHnhKFkexS5Na9nTaVZ7dzGhQqrVOMH9/ah5fSlmG8 weRDqwawPELBSDFaIVPKtK8hh+NqOHv+ixxIfVXz1bszGub+bG88eGv0q5tRbW5/ 5Lq/m2IEl5X7S7zAZetOHzxtm6/5WhbY+ianlnEb5gktn4zAKKk24Q345PX9ICQ+ eNLUbaHT5roxvYu6VvY/Ju1eCHMTc6fl6dTVLS9DlD0Y0X9kWHOeoqYNDG3tDoO4 VaI2N4bCijCGuN3BrP2WZJqoe1iK3nN++xOfTVsnZO5s0U+ax4B7BmLSZrSX+M8= =d6pZ -----END PGP SIGNATURE----- --tj0VjRR6QdMEboSBAlmbHXnEtsGqWX1TR--