From: Christopher Covington <cov@codeaurora.org>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 4/7] target-arm: Implement pmccntr_sync function
Date: Tue, 24 Jun 2014 11:35:16 -0400 [thread overview]
Message-ID: <53A99AB4.60804@codeaurora.org> (raw)
In-Reply-To: <ffad73da5eb3c43aeb7e72922a0dd3eadeb063d5.1403572003.git.alistair.francis@xilinx.com>
On 06/23/2014 09:12 PM, Alistair Francis wrote:
> This is used to synchronise the PMCCNTR counter and swap its
> state between enabled and disabled if required. It must always
> be called twice, both before and after any logic that could
> change the state of the PMCCNTR counter.
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 31aa09c..0984eda 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -1051,6 +1051,17 @@ static inline bool cp_access_ok(int current_pl,
> }
>
> /**
> + * pmccntr_sync
> + * @cpu: ARMCPU
> + *
> + * Syncronises the counter in the PMCCNTR. This must always be called twice,
> + * once before any action that might effect the timer and again afterwards.
> + * The fucntion is used to swap the state of the register if required.
Nit: function
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
next prev parent reply other threads:[~2014-06-24 15:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 1:11 [Qemu-devel] [PATCH v1 0/7] target-arm: Extend PMCCNTR for ARMv8 Alistair Francis
2014-06-24 1:11 ` [Qemu-devel] [PATCH v1 1/7] target-arm: Make the ARM PMCCNTR register 64-bit Alistair Francis
2014-06-24 1:11 ` [Qemu-devel] [PATCH v1 2/7] target-arm: Implement PMCCNTR_EL0 and related registers Alistair Francis
2014-06-24 1:12 ` [Qemu-devel] [PATCH v1 3/7] target-arm: Add helper macros and defines for CCNT register Alistair Francis
2014-06-24 15:31 ` Christopher Covington
2014-06-24 22:40 ` Alistair Francis
2014-06-24 15:56 ` Peter Maydell
2014-06-24 22:42 ` Alistair Francis
2014-06-24 1:12 ` [Qemu-devel] [PATCH v1 4/7] target-arm: Implement pmccntr_sync function Alistair Francis
2014-06-24 15:35 ` Christopher Covington [this message]
2014-06-24 22:34 ` Alistair Francis
2014-06-24 1:12 ` [Qemu-devel] [PATCH v1 5/7] target-arm: Remove old code and replace with new functions Alistair Francis
2014-06-24 1:12 ` [Qemu-devel] [PATCH v1 6/7] target-arm: Implement pmccfiltr_write function Alistair Francis
2014-06-24 1:12 ` [Qemu-devel] [PATCH v1 7/7] target-arm: Call the pmccntr_sync function when swapping ELs Alistair Francis
2014-06-24 15:55 ` Christopher Covington
2014-06-24 22:39 ` Alistair Francis
2014-06-24 23:07 ` Peter Crosthwaite
2014-06-26 0:37 ` Alistair Francis
2014-06-26 11:40 ` Peter Crosthwaite
2014-06-26 11:43 ` Peter Crosthwaite
2014-06-26 14:58 ` [Qemu-devel] [PATCH v1 0/7] target-arm: Extend PMCCNTR for ARMv8 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A99AB4.60804@codeaurora.org \
--to=cov@codeaurora.org \
--cc=alistair.francis@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).