From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53804)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1WzTLs-0002W1-P6
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 12:13:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1WzTLj-0006qc-N6
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 12:13:44 -0400
Received: from mail-lb0-x233.google.com ([2a00:1450:4010:c04::233]:62125)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1WzTLj-0006qQ-Fn
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 12:13:35 -0400
Received: by mail-lb0-f179.google.com with SMTP id z11so768069lbi.38
	for <qemu-devel@nongnu.org>; Tue, 24 Jun 2014 09:13:34 -0700 (PDT)
Message-ID: <53A9A3AC.6010703@gmail.com>
Date: Tue, 24 Jun 2014 20:13:32 +0400
From: Sergey Fedorov <serge.fdrv@gmail.com>
MIME-Version: 1.0
References: <1403183756-24664-1-git-send-email-serge.fdrv@gmail.com>
	<53A9A202.3010004@msgid.tls.msk.ru>
In-Reply-To: <53A9A202.3010004@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: put gprof config in host config
	file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Richard Henderson <rth@twiddle.net>


On 24.06.2014 20:06, Michael Tokarev wrote:
> 19.06.2014 17:15, Sergey Fedorov wrote:
>> The only use for GPROF_CFLAGS is in main makefile, but this variable put
>> only to taget config file which is not included to the main makefile.
>> Lets put gprof config variables to host config file.
> I'm not sure I follow.
>
> First of all, GPROF_CFLAGS is referenced in Makefile.objs, not the
> main makefile.  And Makefile.objs _is_ included by the main Makefile.
>
> Second, now you're including this variable into 2 places.
>
> Maybe it is better to stop putting it to the target config file
> at the same time?
>
> What problem you're trying to solve?
>
> Maybe some more details will help?

I'm sorry. Seems the patch is based on v2.0.0, not current master. So
this patch can be ignore.

// Sergey

>
> Thanks,
>
> /mjt
>
>> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
>> ---
>>  configure | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index dfbe75e..e0433b9 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4323,6 +4323,10 @@ fi
>>  if test "$profiler" = "yes" ; then
>>    echo "CONFIG_PROFILER=y" >> $config_host_mak
>>  fi
>> +if test "$gprof" = "yes" ; then
>> +  echo "CONFIG_GPROF=y" >> $config_host_mak
>> +  echo "GPROF_CFLAGS=-p" >> $config_host_mak
>> +fi
>>  if test "$slirp" = "yes" ; then
>>    echo "CONFIG_SLIRP=y" >> $config_host_mak
>>    echo "CONFIG_SMBD_COMMAND=\"$smbd\"" >> $config_host_mak
>> @@ -5160,7 +5164,7 @@ alpha)
>>  esac
>>  
>>  if test "$gprof" = "yes" ; then
>> -  echo "TARGET_GPROF=yes" >> $config_target_mak
>> +  echo "TARGET_GPROF=y" >> $config_target_mak
>>    if test "$target_linux_user" = "yes" ; then
>>      cflags="-p $cflags"
>>      ldflags="-p $ldflags"
>>