From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <wenchaoqemu@gmail.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH FOR 2.1 2/5] qapi: move event defines
Date: Tue, 24 Jun 2014 20:15:09 -0600 [thread overview]
Message-ID: <53AA30AD.20302@redhat.com> (raw)
In-Reply-To: <1403652840-13449-3-git-send-email-wenchaoqemu@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On 06/24/2014 05:33 PM, Wenchao Xia wrote:
> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
> ---
> Makefile | 2 +-
> qapi-event.json | 318 ------------------------------------------------------
> qapi-schema.json | 5 +-
> qapi/event.json | 318 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 322 insertions(+), 321 deletions(-)
> delete mode 100644 qapi-event.json
> create mode 100644 qapi/event.json
Please run:
git config diff.renames true
then this patch would be MUCH smaller on the list.
Fortunately, it was a fairly easy review.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-25 2:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 23:33 [Qemu-devel] [PATCH FOR 2.1 0/5] clean up for qapi event Wenchao Xia
2014-06-24 23:33 ` [Qemu-devel] [PATCH FOR 2.1 1/5] tests/test-qmp-event: fix for GLib < 2.31 Wenchao Xia
2014-06-25 13:13 ` Luiz Capitulino
2014-06-25 13:15 ` Paolo Bonzini
2014-06-27 18:28 ` Luiz Capitulino
2014-06-29 20:31 ` Peter Maydell
2014-06-30 10:53 ` Paolo Bonzini
2014-07-01 14:32 ` Wenchao Xia
2014-06-24 23:33 ` [Qemu-devel] [PATCH FOR 2.1 2/5] qapi: move event defines Wenchao Xia
2014-06-25 2:15 ` Eric Blake [this message]
2014-06-24 23:33 ` [Qemu-devel] [PATCH FOR 2.1 3/5] qapi: ignore generated event files Wenchao Xia
2014-06-25 2:20 ` Eric Blake
2014-06-24 23:33 ` [Qemu-devel] [PATCH FOR 2.1 4/5] qapi script: clean up in scripts Wenchao Xia
2014-06-25 2:39 ` Eric Blake
2014-06-24 23:34 ` [Qemu-devel] [PATCH FOR 2.1 5/5] qapi event: clean up in callers Wenchao Xia
2014-06-25 2:48 ` Eric Blake
2014-06-25 15:36 ` [Qemu-devel] [PATCH FOR 2.1 0/5] clean up for qapi event Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AA30AD.20302@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wenchaoqemu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).