From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzd7t-0005TW-5K for qemu-devel@nongnu.org; Tue, 24 Jun 2014 22:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wzd7k-0003iM-4S for qemu-devel@nongnu.org; Tue, 24 Jun 2014 22:39:56 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:41490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzd7j-0003i6-V3 for qemu-devel@nongnu.org; Tue, 24 Jun 2014 22:39:48 -0400 Received: by mail-pb0-f52.google.com with SMTP id rq2so1049918pbb.11 for ; Tue, 24 Jun 2014 19:39:46 -0700 (PDT) Message-ID: <53AA366B.1030806@ozlabs.ru> Date: Wed, 25 Jun 2014 12:39:39 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1403632924-16603-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1403632924-16603-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] Introduce common QEMU_COMPAT_* macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org, "Michael S. Tsirkin" Cc: Peter Maydell , Marcel Apfelbaum , Markus Armbruster , Paul Mackerras , Anthony Liguori , Igor Mammedov , Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Alexander Graf On 06/25/2014 04:02 AM, Eduardo Habkost wrote: > This series is an attempt to make the compat_props lists from the PC code > reusable by other machine-types. All the compat bits that are on those lists are > not tied to a specific machine-type, but instead to the device code that was > present on a given QEMU version. > > The last patch is a proposal to simply eliminate the PC-specific compat props > macros, because we don't really need them today. All compat properties we have > can be on global QEMU-version-specific lists, because PC-specific properties are > not going to affect other machine-types anyway. The idea is cool, the separation of which properties go to boards.h and which stay in hw/i386/pc_piix.c is not clear though (PIIX is unlikely to be wanted somewhere else but virtio is). > > Eduardo Habkost (4): > q35: Move q35-specific compat macros to pc_q35.c > pc: Eliminate nesting of common PC_COMPAT_* macros > machine: Introduce QEMU_COMPAT_* macros > [RFC] Eliminate PC-specific compat_props > > hw/i386/pc_piix.c | 31 +++++-- > hw/i386/pc_q35.c | 19 +++++ > include/hw/boards.h | 207 +++++++++++++++++++++++++++++++++++++++++++++++ > include/hw/i386/pc.h | 224 --------------------------------------------------- > 4 files changed, 251 insertions(+), 230 deletions(-) -- Alexey