From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzeH8-0002qP-8K for qemu-devel@nongnu.org; Tue, 24 Jun 2014 23:53:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzeGy-0000VO-Tn for qemu-devel@nongnu.org; Tue, 24 Jun 2014 23:53:34 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:49679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzeGy-0000TJ-2b for qemu-devel@nongnu.org; Tue, 24 Jun 2014 23:53:24 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Jun 2014 13:53:17 +1000 Message-ID: <53AA47AA.1010700@au1.ibm.com> Date: Wed, 25 Jun 2014 13:53:14 +1000 From: Sam Bobroff MIME-Version: 1.0 References: <53A8C4D1.6060300@au1.ibm.com> <53A969DE.8050103@suse.de> In-Reply-To: <53A969DE.8050103@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/4] spapr: improve RTAS get_system_parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 24/06/14 22:06, Alexander Graf wrote: > > On 24.06.14 02:22, Sam Bobroff wrote: >> This series of patches improves QEMU's emulation of the RTAS call >> "ibm,get-system-parameter" by adding support for the "UUID" and "SPLPAR >> Characteristics" parameters as well as fixing a problem in the the >> implementation of the "Platform Processor Diagnostics Run Mode" parameter. >> >> It also improves the surrounding code a little to support the addition of >> additional system parameters. > > Very nice patch set. Please address the few minor nits I had on it, send a v2 and it's ready to go in I think ;) > > > Alex Great, thanks for the review :-) I think I've addressed all the issues and I'll post a v2 shortly. Cheers, Sam B.