From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40816)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1Wzi2A-0005I9-T5
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 03:54:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1Wzi22-000618-Rc
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 03:54:22 -0400
Received: from mga02.intel.com ([134.134.136.20]:13742)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1Wzi22-00060w-LF
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 03:54:14 -0400
Message-ID: <53AA801A.80806@intel.com>
Date: Wed, 25 Jun 2014 15:54:02 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1403662641-28526-1-git-send-email-tiejun.chen@intel.com>
	<1403662641-28526-4-git-send-email-tiejun.chen@intel.com>
	<53AA6B68.7050406@redhat.com>
In-Reply-To: <53AA6B68.7050406@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v5][PATCH 3/5] xen,
 gfx passthrough: support Intel IGD passthrough with VT-D
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com, mst@redhat.com, Kelly.Zytaruk@amd.com
Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, yang.z.zhang@intel.com

On 2014/6/25 14:25, Paolo Bonzini wrote:
> Il 25/06/2014 04:17, Tiejun Chen ha scritto:
>> +int pci_create_pch(PCIBus *bus)
>> +{
>> +    XenHostPCIDevice hdev;
>> +    int r = 0;
>> +
>> +    if (!xen_has_gfx_passthru) {
>> +        return r;
>> +    }
>> +
>
> You could make this an assertion, since the function is never called
> with xen_has_gfx_passthru == 0.  Or just drop the check completely, so

I will drop this completely.

Thanks
Tiejun

> the function can be moved in patch 2.
>
> Paolo
>
>