Re: [Qemu-devel] [PATCH v3 8/9] vmstate: Add preallocation for migrating arrays (VMS_ALLOC flag)

[Alexander Graf <agraf@suse.de>]

On 25.06.14 13:41, Juan Quintela wrote:
> Alexander Graf <agraf@suse.de> wrote:
>> On 06/12/2014 05:02 PM, Alexey Kardashevskiy wrote:
>>> On 06/08/2014 09:59 AM, Alexey Kardashevskiy wrote:
>>>> On 06/03/2014 11:19 PM, Alexey Kardashevskiy wrote:
>>>>> On 05/30/2014 07:34 PM, Alexey Kardashevskiy wrote:
>>>>>> There are few helpers already to support array migration. However they all
>>>>>> require the destination side to preallocate arrays before migration which
>>>>>> is not always possible due to unknown array size as it might be some
>>>>>> sort of dynamic state. One of the examples is an array of MSIX-enabled
>>>>>> devices in SPAPR PHB - this array may vary from 0 to 65536 entries and
>>>>>> its size depends on guest's ability to enable MSIX or do PCI hotplug.
>>>>>>
>>>>>> This adds new VMSTATE_VARRAY_STRUCT_ALLOC macro which is pretty similar to
>>>>>> VMSTATE_STRUCT_VARRAY_POINTER_INT32 but it can alloc memory for migratign
>>>>>> array on the destination side.
>>>>>>
>>>>>> This defines VMS_ALLOC flag for a field.
>>>>>>
>>>>>> This changes vmstate_base_addr() to do the allocation when receiving
>>>>>> migration.
>>>>>
>>>>> Juan, Peter? No hurry, just pinging in order not to forget :) Thanks!
>>>> Hi, anyone? :)
>>> Ping?
>> Acked-by: Alexander Graf <agraf@suse.de>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> BTW, should I include it, or will it got include through this series?

Thanks a lot for the review :). I'll pick it up - the next patch depends 
on it and we're getting very close to hard freeze.


Alex