From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzniS-0006Cd-AO for qemu-devel@nongnu.org; Wed, 25 Jun 2014 09:58:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzniM-0003iy-8R for qemu-devel@nongnu.org; Wed, 25 Jun 2014 09:58:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzniL-0003gz-Uy for qemu-devel@nongnu.org; Wed, 25 Jun 2014 09:58:18 -0400 Message-ID: <53AAD576.5000405@redhat.com> Date: Wed, 25 Jun 2014 07:58:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403696346-9255-1-git-send-email-mst@redhat.com> In-Reply-To: <1403696346-9255-1-git-send-email-mst@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FPN01EM8EumGCjA9rATlbVAQP6Lb8bcrE" Subject: Re: [Qemu-devel] [PATCH v4] mc146818rtc: add rtc-reset-reinjection QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Marcelo Tosatti , Markus Armbruster , Stefan Hajnoczi , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FPN01EM8EumGCjA9rATlbVAQP6Lb8bcrE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/25/2014 05:40 AM, Michael S. Tsirkin wrote: > It is necessary to reset RTC interrupt reinjection backlog if > guest time is synchronized via a different mechanism, such as > QGA's guest-set-time command. >=20 > Failing to do so causes both corrections to be applied (summed), > resulting in an incorrect guest time. >=20 > Signed-off-by: Marcelo Tosatti > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- >=20 > Marcelo, is this right? >=20 > Changes from v3: > rebase on top of master > fixes error code > drop dead code >=20 > qapi-schema.json | 12 ++++++++++++ > hw/timer/mc146818rtc.c | 18 ++++++++++++++++++ > monitor.c | 7 +++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > 4 files changed, 60 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FPN01EM8EumGCjA9rATlbVAQP6Lb8bcrE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTqtV2AAoJEKeha0olJ0Nq9HgH/jfb+CWGXGHvYCblsZCTonzk sgdkSn08oT6IJj3wv+Wi3uyjAjWb3eiMy30MVcXi734T5+WM28vtg4rbFbRJQgx4 qx/ruGz+v/PeKL/Ul5RVurfqhv+8t61I9m7vJ6pT00XvkQgvUJ9Qlj/CiKaLv7Gs ADWlwKYvqoK36gDon7JoDqjhytoyTOw6Db/+ciTS7cW7NArRGWxruN22QV+uhhog tEx+mnTeXu3gjmQ1vv/tiKLC7wgbGew0eS4iV/h3zs3MIT7sQYhhd7McyreyTVIq 1AEonZ0Y61wGMPA0FKOAKJZKo6qcUOu95XTDqqTok7sGbzMMQsHpuVLS7V0oE7g= =ZcnH -----END PGP SIGNATURE----- --FPN01EM8EumGCjA9rATlbVAQP6Lb8bcrE--