From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzowT-0007D5-Dr for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzowJ-00026B-M0 for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:16:57 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:40753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzowJ-00024Z-I2 for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:16:47 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Jun 2014 11:16:47 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 0E446C90042 for ; Wed, 25 Jun 2014 11:16:39 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23033.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s5PFGjHs9175524 for ; Wed, 25 Jun 2014 15:16:45 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s5PFGiFE024400 for ; Wed, 25 Jun 2014 11:16:45 -0400 Message-ID: <53AAE7DB.6090409@linux.vnet.ibm.com> Date: Wed, 25 Jun 2014 11:16:43 -0400 From: Matthew Rosato MIME-Version: 1.0 References: <1403706420-20109-1-git-send-email-mjrosato@linux.vnet.ibm.com> <1403706420-20109-2-git-send-email-mjrosato@linux.vnet.ibm.com> <20140625165345.62c04ba2@nial.usersys.redhat.com> In-Reply-To: <20140625165345.62c04ba2@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/3] sclp-s390: Add device to manage s390 memory hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, aliguori@amazon.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, rth@twiddle.net On 06/25/2014 10:53 AM, Igor Mammedov wrote: > On Wed, 25 Jun 2014 10:26:58 -0400 > Matthew Rosato wrote: > >> Add sclpMemoryHotplugDev to contain associated data structures, etc. >> >> Signed-off-by: Matthew Rosato >> --- >> hw/s390x/sclp.c | 30 ++++++++++++++++++++++++++++++ >> include/hw/s390x/sclp.h | 20 ++++++++++++++++++++ >> 2 files changed, 50 insertions(+) >> >> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c >> index d8ddf35..769d7c3 100644 >> --- a/hw/s390x/sclp.c >> +++ b/hw/s390x/sclp.c >> @@ -183,3 +183,33 @@ void s390_sclp_init(void) >> OBJECT(dev), NULL); >> qdev_init_nofail(dev); >> } >> + >> +sclpMemoryHotplugDev *init_sclp_memory_hotplug_dev(void) >> +{ >> + DeviceState *dev; >> + dev = qdev_create(NULL, TYPE_SCLP_MEMORY_HOTPLUG_DEV); >> + object_property_add_child(qdev_get_machine(), >> + TYPE_SCLP_MEMORY_HOTPLUG_DEV, >> + OBJECT(dev), NULL); >> + qdev_init_nofail(dev); >> + return SCLP_MEMORY_HOTPLUG_DEV(object_resolve_path( >> + TYPE_SCLP_MEMORY_HOTPLUG_DEV, NULL)); >> +} >> + >> +sclpMemoryHotplugDev *get_sclp_memory_hotplug_dev(void) >> +{ >> + return SCLP_MEMORY_HOTPLUG_DEV(object_resolve_path( >> + TYPE_SCLP_MEMORY_HOTPLUG_DEV, NULL)); >> +} >> + >> +static TypeInfo sclp_memory_hotplug_dev_info = { >> + .name = TYPE_SCLP_MEMORY_HOTPLUG_DEV, >> + .parent = TYPE_SYS_BUS_DEVICE, >> + .instance_size = sizeof(sclpMemoryHotplugDev), > > Either parent above should be TYPE_DEVICE or > s/DeviceState/SysBusDevice/ below > Oops, good catch - I tested s/DeviceState/SysBusDevice/ and will include it in the next version. Thanks. >> +struct sclpMemoryHotplugDev { >> + DeviceState parent; > > >