From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpGu-0004Pl-2t for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:38:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzpGl-00025O-FE for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:38:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpGl-00025A-7M for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:37:55 -0400 Message-ID: <53AAECCF.5000505@redhat.com> Date: Wed, 25 Jun 2014 09:37:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403706959-6979-1-git-send-email-kwolf@redhat.com> <1403706959-6979-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1403706959-6979-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t21Tj0EOSJMIXRRl0t5xECnwE5gFfOnFc" Subject: Re: [Qemu-devel] [PATCH v2 1/9] block: Create bdrv_fill_options() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: benoit.canet@irqsave.net, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --t21Tj0EOSJMIXRRl0t5xECnwE5gFfOnFc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/25/2014 08:35 AM, Kevin Wolf wrote: > The idea of bdrv_fill_options() is to convert every parameter for > opening images, in particular the filename and flags, to entries in the= > options QDict. >=20 > This patch starts with moving the filename parsing and driver probing > part from bdrv_file_open() to the new function. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 112 +++++++++++++++++++++++++++++++++++++++-----------------= -------- > 1 file changed, 69 insertions(+), 43 deletions(-) >=20 > + * Fills in default options for opening images and converts the legacy= > + * filename/flags pair to option QDict entries. > */ > -static int bdrv_file_open(BlockDriverState *bs, const char *filename, > - QDict **options, int flags, Error **errp) > +static int bdrv_fill_options(QDict **options, const char *filename, > + Error **errp) Still looks odd to reference filename/flags pair in the comments when there is no flags argument, but it gets fixed later in the series so I can overlook it. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --t21Tj0EOSJMIXRRl0t5xECnwE5gFfOnFc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTquzPAAoJEKeha0olJ0NqKnkH/2rcIe98XzLVYB/MS8vgAU0F 2kN44KzZW8MqUMvV6ZTVpPj3BJo3SBS6FffkNdzG3gHI9JXSmwuu88o7vxn9pZwi BsyRreuF/YM1k1X5YpFTk4R5QFb3zICwOxPDTvd9ak6NUOf8YCjAw3HJVj5IAnU0 iCWJVzT4wZbp2o10+0e1p4NRPdipwx3/GGNt69p3EmYJ7xR4GoUbX1sihZrYZZxg fX2mWyUDVifrHJIcuG8T8roJjdHzSlEwLLjEL9qie5XZXP0yiI0RpAFLSmKgQ/QA Yb7I6JOkBerLtMf74uSerg7D1yFjlKYCXlOmlknqj5BWneePhalOYrnIQOC5eqo= =jh3P -----END PGP SIGNATURE----- --t21Tj0EOSJMIXRRl0t5xECnwE5gFfOnFc--