From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpJH-0007bq-FF for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:40:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzpJB-00036o-71 for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:40:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpJA-00036b-Ui for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:40:25 -0400 Message-ID: <53AAED65.2050809@redhat.com> Date: Wed, 25 Jun 2014 09:40:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403706959-6979-1-git-send-email-kwolf@redhat.com> <1403706959-6979-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1403706959-6979-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ufOVHo387vlA6UFQPaAXum1RcjwWuVDqT" Subject: Re: [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to bdrv_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: benoit.canet@irqsave.net, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ufOVHo387vlA6UFQPaAXum1RcjwWuVDqT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/25/2014 08:35 AM, Kevin Wolf wrote: > bs->options now contains the modified version of the options. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) >=20 > diff --git a/block.c b/block.c > index f1c3b57..b1087e6 100644 > --- a/block.c > +++ b/block.c > @@ -1009,14 +1009,19 @@ free_and_fail: > * Fills in default options for opening images and converts the legacy= > * filename/flags pair to option QDict entries. > */ > -static int bdrv_fill_options(QDict **options, const char *filename, > +static int bdrv_fill_options(QDict **options, const char *filename, in= t flags, > Error **errp) Yep, that cleans up my comment in 1/9. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ufOVHo387vlA6UFQPaAXum1RcjwWuVDqT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTqu1lAAoJEKeha0olJ0NqgesH/iuNrnjfcFkBq1cwuZIJPb78 3oyQxl7ya4lr0WMzs3C7lF0yVRo5NmbzOrm0WGm/BrTqk0Y1+F6yga8jNu2nWz45 /TdUlyQ9RZv1ymCJ5giLn3vpZj53WtPgl+npXQJNP1kJU0f3sQpFPLzrqT/VWT9u 701hGZwD30ghevQn0XtFyIKQTfVP9c9Gqokjiq7VEcnAJXfwvDioBcvQYE1DLSC6 WrzvWmL7xzcCGIo0NVvi7WvmNaJxr2brMUuxs3b1NEHFkVRn1NaZK0M6sK3mrlCj 6GwWa8jeYQgiYw9AB4CbxU8i/htHHjgvDsciCBERD/8g9NUhrLPfMLkyPR/GeWE= =NcB3 -----END PGP SIGNATURE----- --ufOVHo387vlA6UFQPaAXum1RcjwWuVDqT--