From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpRs-0005Hk-8h for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:49:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzpRn-0006ej-5r for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:49:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpRm-0006ed-U0 for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:49:19 -0400 Message-ID: <53AAEF7A.8010403@redhat.com> Date: Wed, 25 Jun 2014 09:49:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403706959-6979-1-git-send-email-kwolf@redhat.com> <1403706959-6979-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1403706959-6979-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dRDBj61Jo2o4xCfkO9lwO13GqCTeNKMMD" Subject: Re: [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: benoit.canet@irqsave.net, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dRDBj61Jo2o4xCfkO9lwO13GqCTeNKMMD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/25/2014 08:35 AM, Kevin Wolf wrote: > It doesn't do much any more, we can move the code to bdrv_open() now. >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Benoit Canet > --- > block.c | 51 +++++++++++---------------------------------------- > 1 file changed, 11 insertions(+), 40 deletions(-) >=20 > if (!ret) { > + bs->growable =3D 1; Is it worth converting bs->growable to bool at some point in this series? But saving it for a separate patch is wise, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dRDBj61Jo2o4xCfkO9lwO13GqCTeNKMMD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTqu96AAoJEKeha0olJ0NqZskIAK67U7v1F1kWNM4F1FPs4XaG cRNe3HupX4DhVjiaJsD65tBQdNxFPkFBU4tT8VpJHJ5p0ua1Ncc+HUw06CTp6lxl 2m2Y51uvXVJXsUYeR4CYB4WfiXFN0lDbvHfvSO0jt4+Y6r0UGgwsu0rx5hSNqpGX 2CoH5VkbMhTWI8G+o3vKXjmgMQFReFwOtJSD8C5mHlxH9iy4/a+51hmsLbx09AVt dZCJOQdEBHMTT7m1BTobW/WkyK5sHs/Aq2Gd3y2en59yyJQOnNZldrYuIxt5Nirb Tr7ZSnC54gW0Yl2kL3nsX5Ze+zcH0B7y4SSlEncIw0XoIFn8iqqF4m83VHgAY4c= =c2Gl -----END PGP SIGNATURE----- --dRDBj61Jo2o4xCfkO9lwO13GqCTeNKMMD--