From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: benoit.canet@irqsave.net, armbru@redhat.com, stefanha@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion
Date: Wed, 25 Jun 2014 09:52:25 -0600 [thread overview]
Message-ID: <53AAF039.2030605@redhat.com> (raw)
In-Reply-To: <1403706959-6979-8-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On 06/25/2014 08:35 AM, Kevin Wolf wrote:
> This recursion was introduced in commit 505d7583 in order to allow
> nesting image formats. It only ever takes effect when the user
> explicitly specifies a driver name and that driver isn't suitable for
> the protocol level.
>
> We can check this earlier in bdrv_open() and if the explicitly
> requested driver is a format driver, clear BDRV_O_PROTOCOL so that
> another bs->file layer is opened.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 50 +++++++++++++++++++++++++-------------------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-25 15:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 14:35 [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1 Kevin Wolf
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 1/9] block: Create bdrv_fill_options() Kevin Wolf
2014-06-25 15:37 ` Eric Blake
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to bdrv_open() Kevin Wolf
2014-06-25 15:40 ` Eric Blake
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 3/9] block: Move json: parsing to bdrv_fill_options() Kevin Wolf
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 4/9] block: Always pass driver name through options QDict Kevin Wolf
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 5/9] block: Use common driver selection code for bdrv_open_file() Kevin Wolf
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open() Kevin Wolf
2014-06-25 15:49 ` Eric Blake
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion Kevin Wolf
2014-06-25 15:52 ` Eric Blake [this message]
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers Kevin Wolf
2014-06-25 15:53 ` Eric Blake
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 9/9] block: Remove a special case for protocols Kevin Wolf
2014-06-25 15:55 ` Eric Blake
2014-06-26 10:17 ` [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1 Kevin Wolf
2014-06-26 21:17 ` Max Reitz
2014-06-26 21:46 ` Eric Blake
2014-06-26 21:48 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAF039.2030605@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).