From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpUz-0007PL-Cg for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:52:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzpUr-00083b-3L for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:52:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpUq-00083P-Pc for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:52:29 -0400 Message-ID: <53AAF039.2030605@redhat.com> Date: Wed, 25 Jun 2014 09:52:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403706959-6979-1-git-send-email-kwolf@redhat.com> <1403706959-6979-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1403706959-6979-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rEppG3HcHJQf1dxeDuomLxRFLqq2DOtS2" Subject: Re: [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: benoit.canet@irqsave.net, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rEppG3HcHJQf1dxeDuomLxRFLqq2DOtS2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/25/2014 08:35 AM, Kevin Wolf wrote: > This recursion was introduced in commit 505d7583 in order to allow > nesting image formats. It only ever takes effect when the user > explicitly specifies a driver name and that driver isn't suitable for > the protocol level. >=20 > We can check this earlier in bdrv_open() and if the explicitly > requested driver is a format driver, clear BDRV_O_PROTOCOL so that > another bs->file layer is opened. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 50 +++++++++++++++++++++++++------------------------- > 1 file changed, 25 insertions(+), 25 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rEppG3HcHJQf1dxeDuomLxRFLqq2DOtS2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTqvA5AAoJEKeha0olJ0Nq0E4H/ijc2A6AWXPDKE6IXTL2yhPF hpFpplzcWbVMNkMJaLWozVfsimforDrMdHfaGSybR8i8IsHplVf+NJNWGpSIDscx Qz0PQBNrbXnWw6ItjNOskkKiimuhZm0BY+k18n2I6/qXIZogFm+j6VIWwqd87gJP 3o7S5XYC9XSBooOI9WrM2TIwaMTRHLU3wbwmsx+9q8meod9stVHWf9u27iHwcQdz CbJI2h4+FJjDyhFf8VSfm78PKIXEBqOf840oKid8pacJULEfiJ/Td9/0C8i8JRjC NjLxPuwgcJaaAvtjHUIFN0tDl5SxUlTXmOkBsxqKkM4u2POGrX39lqnRO5Cwv3E= =4+4p -----END PGP SIGNATURE----- --rEppG3HcHJQf1dxeDuomLxRFLqq2DOtS2--