From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpWM-0008T2-Ad for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:54:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzpWG-0000Hk-Iy for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:54:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpWG-0000HY-9J for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:53:56 -0400 Message-ID: <53AAF091.6060208@redhat.com> Date: Wed, 25 Jun 2014 09:53:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403706959-6979-1-git-send-email-kwolf@redhat.com> <1403706959-6979-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1403706959-6979-9-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mgNVQ8p5mXjkD8Io91sRG5A90Khi5iIO3" Subject: Re: [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: benoit.canet@irqsave.net, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mgNVQ8p5mXjkD8Io91sRG5A90Khi5iIO3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/25/2014 08:35 AM, Kevin Wolf wrote: > Since we parse backing.* options to add a backing file from the command= > line when the driver didn't assign one, it has been possible to have a > backing file for e.g. raw images (it just was never accessed). >=20 > This is obvious nonsense and should be rejected. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 7 +++++++ > block/cow.c | 1 + > block/qcow.c | 1 + > block/qcow2.c | 1 + > block/qed.c | 1 + > block/vmdk.c | 1 + > include/block/block_int.h | 3 +++ > tests/qemu-iotests/051 | 5 +++++ > tests/qemu-iotests/051.out | 9 +++++++++ > 9 files changed, 29 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mgNVQ8p5mXjkD8Io91sRG5A90Khi5iIO3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTqvCRAAoJEKeha0olJ0NqV54H/1+xp7DkD0v6G3LLeofGfGEO WKjouEGj5oGrRpcBJj4TAHiI4LGfb4CKJKWU6QV0XHNUSci3GrylLNrx2UB+78kg aExs787tvTEfHSytw2HCWMD5uNdmrN1X0vBIOpzJDL1b5/pLOC//4FSisNxkZG7w SsGaj4EHMP+6B+FcnGxPBiUNMYu8iWyOa/J8DqyKF8wofCrTRLBonI7i6lA1pmO3 65kaGEqAlWEyno8KjIvB3rtGjvPodZmfFaq7QnCuNoQ30h4ncd0KWc/5kMOYqydY SFeMcLKhikYwyvk4yBQKECwm0DIysL8KkJRY2/cjrGUIc6pSzlfgvvs87ZegoDw= =ekdK -----END PGP SIGNATURE----- --mgNVQ8p5mXjkD8Io91sRG5A90Khi5iIO3--