From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X04Hg-0006yF-KI for qemu-devel@nongnu.org; Thu, 26 Jun 2014 03:39:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X04Hc-0000eC-9Y for qemu-devel@nongnu.org; Thu, 26 Jun 2014 03:39:52 -0400 Received: from greensocs.com ([178.33.234.66]:55459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X04Hb-0000e8-VP for qemu-devel@nongnu.org; Thu, 26 Jun 2014 03:39:48 -0400 Message-ID: <53ABCE42.2020704@greensocs.com> Date: Thu, 26 Jun 2014 09:39:46 +0200 From: Frederic Konrad MIME-Version: 1.0 References: <1403709607-6434-1-git-send-email-fred.konrad@greensocs.com> <1403709607-6434-11-git-send-email-fred.konrad@greensocs.com> <534C5107B281854290643468BBAAD41F17293E@G08CNEXMBPEKD01.g08.fujitsu.local> In-Reply-To: <534C5107B281854290643468BBAAD41F17293E@G08CNEXMBPEKD01.g08.fujitsu.local> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] =?gb2312?b?tPC4tDogIFtSRkMgUEFUQ0ggdjUgMTAvMTNdIGdk?= =?gb2312?b?YnN0dWI6IGFsbG93IHJldmVyc2UgZXhlY3V0aW9uIGluIGdkYiBzdHViLg==?= List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "lig.fnst@cn.fujitsu.com" , "qemu-devel@nongnu.org" Cc: "peter.maydell@linaro.org" , "quintela@redhat.com" , "mark.burton@greensocs.com" , "dgilbert@redhat.com" , "amit.shah@redhat.com" , "pbonzini@redhat.com" , "vilanova@ac.upc.edu" On 26/06/2014 04:50, lig.fnst@cn.fujitsu.com wrote: > Hi,=20 > > Why not a gdb record support? > > Thanks! > Li Guang Hi, Good idea. We didn't think about that yet. It might be done in a futur patch-set. Thanks, Fred >> -----=D3=CA=BC=FE=D4=AD=BC=FE----- >> =B7=A2=BC=FE=C8=CB: qemu-devel-bounces+lig.fnst=3Dcn.fujitsu.com@nongn= u.org >> [mailto:qemu-devel-bounces+lig.fnst=3Dcn.fujitsu.com@nongnu.org] =B4=FA= =B1=ED >> fred.konrad@greensocs.com >> =B7=A2=CB=CD=CA=B1=BC=E4: 2014=C4=EA6=D4=C225=C8=D5 23:20 >> =CA=D5=BC=FE=C8=CB: qemu-devel@nongnu.org >> =B3=AD=CB=CD: peter.maydell@linaro.org; quintela@redhat.com; >> mark.burton@greensocs.com; dgilbert@redhat.com; amit.shah@redhat.com; >> pbonzini@redhat.com; vilanova@ac.upc.edu; fred.konrad@greensocs.com >> =D6=F7=CC=E2: [Qemu-devel] [RFC PATCH v5 10/13] gdbstub: allow reverse= execution in >> gdb stub. >> >> From: KONRAD Frederic >> >> This allows gdb to reverse step QEMU: reverse-stepi and reverse-cont >> commands are allowed. >> >> When step_backward is called, QEMU restores a snapshot before the actu= al >> instruction and stops (with a debug exit) when the previous instructio= n is >> reached. >> >> Signed-off-by: KONRAD Frederic >> --- >> gdbstub.c | 31 ++++++++++++++++++++++++++++++- >> 1 file changed, 30 insertions(+), 1 deletion(-) >> >> diff --git a/gdbstub.c b/gdbstub.c >> index 8afe0b7..99769af 100644 >> --- a/gdbstub.c >> +++ b/gdbstub.c >> @@ -33,6 +33,7 @@ >> #include "sysemu/char.h" >> #include "sysemu/sysemu.h" >> #include "exec/gdbstub.h" >> +#include "reverse-execution.h" >> #endif >> >> #define MAX_PACKET_LENGTH 4096 >> @@ -1113,6 +1114,17 @@ static int gdb_handle_packet(GDBState *s, const >> char *line_buf) >> if (cc->gdb_core_xml_file !=3D NULL) { >> pstrcat(buf, sizeof(buf), ";qXfer:features:read+"); >> } >> + >> + #ifndef CONFIG_USER_ONLY >> + /* >> + * When reverse execution is enabled those additional >> features must >> + * be set so GDB allows reverse-stepi and reverse-continu= e >> command. >> + */ >> + if (cexe_is_enabled()) { >> + pstrcat(buf, sizeof(buf), >> ";ReverseStep+;ReverseContinue+"); >> + } >> + #endif /* !CONFIG_USER_ONLY */ >> + >> put_packet(s, buf); >> break; >> } >> @@ -1161,7 +1173,23 @@ static int gdb_handle_packet(GDBState *s, const >> char *line_buf) >> } >> /* Unrecognised 'q' command. */ >> goto unknown_command; >> - >> + #ifndef CONFIG_USER_ONLY >> + case 'b': >> + /* Reverse execution. */ >> + switch (*p) { >> + case 's': >> + cexe_step_backward(s->c_cpu, 1); >> + break; >> + case 'c': >> + cexe_continue_backward(s->c_cpu); >> + break; >> + default: >> + buf[0] =3D '\0'; >> + put_packet(s, buf); >> + break; >> + } >> + break; >> + #endif /* !CONFIG_USER_ONLY */ >> default: >> unknown_command: >> /* put empty packet */ >> @@ -1221,6 +1249,7 @@ static void gdb_vm_state_change(void *opaque, in= t >> running, RunState state) >> ret =3D GDB_SIGNAL_TRAP; >> break; >> case RUN_STATE_PAUSED: >> + cexe_stop_reverse_continue(); >> ret =3D GDB_SIGNAL_INT; >> break; >> case RUN_STATE_SHUTDOWN: >> -- >> 1.9.0 >>