From: Eric Blake <eblake@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines
Date: Thu, 26 Jun 2014 05:52:45 -0600 [thread overview]
Message-ID: <53AC098D.9060408@redhat.com> (raw)
In-Reply-To: <1403763216-28508-1-git-send-email-hutao@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
On 06/26/2014 12:13 AM, Hu Tao wrote:
> We already have ROUND_UP but there are similar macros and ROUND_UP-like
> lines all around, replace them with ROUND_UP and clean up similar macros.
Not a review (yet), but a question - how did you find lines to convert?
Is there a particular grep pattern you looked for, or a Coccinelle
script, or ...? I ask because it would be nice information in the commit
message, so that the actual review can also look to see if you missed
any instances that could use the conversion.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-26 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 6:13 [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines Hu Tao
2014-06-26 11:52 ` Eric Blake [this message]
2014-06-27 3:41 ` Hu Tao
2014-06-26 16:55 ` Eric Blake
2014-06-27 3:50 ` Hu Tao
2014-07-01 20:42 ` Eric Blake
2014-07-02 7:56 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AC098D.9060408@redhat.com \
--to=eblake@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).