From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X08Eb-0008HY-NO for qemu-devel@nongnu.org; Thu, 26 Jun 2014 07:53:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X08EV-000454-Uy for qemu-devel@nongnu.org; Thu, 26 Jun 2014 07:52:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X08EV-00044z-MR for qemu-devel@nongnu.org; Thu, 26 Jun 2014 07:52:51 -0400 Message-ID: <53AC098D.9060408@redhat.com> Date: Thu, 26 Jun 2014 05:52:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403763216-28508-1-git-send-email-hutao@cn.fujitsu.com> In-Reply-To: <1403763216-28508-1-git-send-email-hutao@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Su3eNf3f5TVNqUnApMEJVQJAVRhwhjKQW" Subject: Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Su3eNf3f5TVNqUnApMEJVQJAVRhwhjKQW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2014 12:13 AM, Hu Tao wrote: > We already have ROUND_UP but there are similar macros and ROUND_UP-like= > lines all around, replace them with ROUND_UP and clean up similar macro= s. Not a review (yet), but a question - how did you find lines to convert? Is there a particular grep pattern you looked for, or a Coccinelle script, or ...? I ask because it would be nice information in the commit message, so that the actual review can also look to see if you missed any instances that could use the conversion. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Su3eNf3f5TVNqUnApMEJVQJAVRhwhjKQW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTrAmNAAoJEKeha0olJ0NquS0IAIA/npT0SFvy6SwwgKnTIhIH g2cVF5rVygq5G3UQaNQ6fGK2vDJU92EfWGJpUmB8mlq9/LAy3g44w7dRyVx0ULB+ vgkOyOMY6hT0gJq9UcRrCgHzco3KLr1tVv+59UQoGX+iAC+XzQJzF4yL38dQR7v7 6R3KdZsHr1s1r6IWegWtzpnvDLZdHT8P4cyoRkoTTghVMo9LMZO2t3J/sTKq4gh0 kEw/uRqKqfVN5XfBqEqPFKgUtOaZIGkmXDv83Z/097D6Dshi3zRrwiwNCM5lsTLj Wdxsre6dc2yZTGC2/yXhuv+Ds3tVDUZJgZ/YaBGkkRtsB9J0mQbLPY7Eo846oqs= =o6lo -----END PGP SIGNATURE----- --Su3eNf3f5TVNqUnApMEJVQJAVRhwhjKQW--