From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X08US-0005wf-L1 for qemu-devel@nongnu.org; Thu, 26 Jun 2014 08:09:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X08UL-0001rc-L4 for qemu-devel@nongnu.org; Thu, 26 Jun 2014 08:09:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X08UL-0001rT-C9 for qemu-devel@nongnu.org; Thu, 26 Jun 2014 08:09:13 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5QC9Cl4001008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 26 Jun 2014 08:09:12 -0400 Message-ID: <53AC0D67.7040402@redhat.com> Date: Thu, 26 Jun 2014 06:09:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403781075-30989-1-git-send-email-lersek@redhat.com> <1403781075-30989-3-git-send-email-lersek@redhat.com> In-Reply-To: <1403781075-30989-3-git-send-email-lersek@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ki3UtoFCmNPOfrOCdrPhhs6cJVtEtqXPf" Subject: Re: [Qemu-devel] [PATCH for-2.1 v2 2/2] char: report frontend open/closed state in 'query-chardev' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , qemu-devel@nongnu.org, mprivozn@redhat.com, kraxel@redhat.com, amit.shah@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ki3UtoFCmNPOfrOCdrPhhs6cJVtEtqXPf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2014 05:11 AM, Laszlo Ersek wrote: > In addition to the on-line reporting added in the previous patch, allow= > libvirt to query frontend state independently of events. >=20 > Libvirt's path to identify the guest agent channel it cares about diffe= rs > between the event added in the previous patch and the QMP response fiel= d > added here. The event identifies the frontend device, by "id". The > 'query-chardev' QMP command identifies the backend device (again by "id= "). > The association is under libvirt's control. >=20 > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=3D1080376 > Signed-off-by: Laszlo Ersek > --- >=20 > ## > -{ 'type': 'ChardevInfo', 'data': {'label': 'str', 'filename': 'str'} }= > +{ 'type': 'ChardevInfo', 'data': {'label': 'str', > + 'filename': 'str', > + 'frontend-open': 'bool'} } Hmm; I wonder if this should instead be 'frontend-status':'VirtioSerialPortStatus', to reuse the type from patch 1/2. That way, if we ever add a third state, then both the event and the poll will be reusing the same enum values to report that state. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ki3UtoFCmNPOfrOCdrPhhs6cJVtEtqXPf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTrA1nAAoJEKeha0olJ0Nqbx8H/3y8R036p4Zo3sxYbZko2+WI zYCKGSGMLBDlytD8gUFFDOngvhup7M9CiNaZnKOpecz2JFbKpazIXZinLdtQdKKP D2Y+gjRL6n1C9iIFk0HFy4V4AokVM3xV6nK0xzOc2KXEqFxJ1L6Ti/Pt3y9A6QKz QisPhq0Gsdwdpyf2S/5TInh/WfvI7zahXRB602xIvfZHUseVD37UFDgsMfc8bD/K 1VSFlNNT+UvdC8HpR48h+3v0bucWqzJ5oKFlkuR+AAYLaLISPhQkNRmZR7+I8ZR3 0RujX0mPjbdMatkl1RcrnMLc70xRHHKLbtoVLtrbFS2ZNn5IJBboBU3TGxLQwf4= =NImb -----END PGP SIGNATURE----- --ki3UtoFCmNPOfrOCdrPhhs6cJVtEtqXPf--