From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X09T5-0006vJ-45 for qemu-devel@nongnu.org; Thu, 26 Jun 2014 09:12:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X09Sy-0006KV-1z for qemu-devel@nongnu.org; Thu, 26 Jun 2014 09:11:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X09Sx-0006IV-QD for qemu-devel@nongnu.org; Thu, 26 Jun 2014 09:11:51 -0400 Message-ID: <53AC1C13.40308@redhat.com> Date: Thu, 26 Jun 2014 07:11:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <4b996aea34144d33f2227835dc3d064818ffb7be.1403688576.git.mprivozn@redhat.com> <53AAD523.3000604@redhat.com> <20140625155048.252833c1@redhat.com> <53AB2D71.7050704@redhat.com> <20140626084611.20f771a2@redhat.com> <53AC19C3.10502@redhat.com> In-Reply-To: <53AC19C3.10502@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nQhB7e40SnmcP5Sl1INEkXPH3vV5TuH0R" Subject: Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Luiz Capitulino Cc: Michal Privoznik , famz@redhat.com, qemu-devel@nongnu.org, Wenchao Xia This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nQhB7e40SnmcP5Sl1INEkXPH3vV5TuH0R Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2014 07:01 AM, Paolo Bonzini wrote: > Il 26/06/2014 14:46, Luiz Capitulino ha scritto: >>> > >>> > Michal's hack at least ensures that we have event documentation, >>> even if >>> > the format changed compared to the 2.0 docs, and even if we don't h= ave >>> > time to get something better in place before 2.1 goes out. So all = of >>> > this conversation on ways to do better is nice, but if we don't get= >>> > there quickly, I could at least live with Michal's patch in the >>> short term. >> I honestly don't know what's the best thing to do here. I can live wit= h >> this patch too, although having some introductory comments at the top = of >> the file saying what it is would be nicer. >=20 > Can we just revert to the pre-conversion qmp-events.txt file? This is > similar to the situation with qmp-commands.hx. As in, carrying redundant information between two files? True that it's no worse than qmp-commands.hx; it would also ensure we aren't regressing on quality of user documentation in relation to prior releases. We could do the restore of that file, but if we do, we should fix the bugs in pre-conversion qmp-events.txt (a couple events were undocumented, there were some grammar errors, all fixed as part of the conversion), as well as document events that have been added post-conversion. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nQhB7e40SnmcP5Sl1INEkXPH3vV5TuH0R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTrBwTAAoJEKeha0olJ0NqZpEH/1FvLLILh1W9WMx72GCcC2G3 nT+KKP+q0UM3h42z9iJEhBTAOuOu5u8YBMfo7u4mdzxTWp1fHZqpnSZv3JJHP78h tAjk2RMevvwd93mFO8CiRM8T01MoFER5UNpCvIR56Q4qcU4QnUaGcuyk5n5g7Sb4 KU5JznF9eos7bYP1nZXxqWbQ7qyi/ilpGLW4NbpH/tEWO4UVIWu8sKGVc1aMWuys hGptk93mYqvludx848TeSDOlLF2Z44rWMMgMVUmgjKKsPhArAOi9sE4rvLxQRrlB Wv3Zq1rQbzPdj31pwQsrZDhVTlOIo6Qzo9W81m3tXkSr1LSL4LjOqCRPgvOuezI= =syDr -----END PGP SIGNATURE----- --nQhB7e40SnmcP5Sl1INEkXPH3vV5TuH0R--