qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>
Cc: Michal Privoznik <mprivozn@redhat.com>,
	famz@redhat.com, qemu-devel@nongnu.org,
	Wenchao Xia <wenchaoqemu@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt
Date: Thu, 26 Jun 2014 15:14:01 +0200	[thread overview]
Message-ID: <53AC1C99.8070106@redhat.com> (raw)
In-Reply-To: <53AC1C13.40308@redhat.com>

Il 26/06/2014 15:11, Eric Blake ha scritto:
>> >
>> > Can we just revert to the pre-conversion qmp-events.txt file?  This is
>> > similar to the situation with qmp-commands.hx.
> As in, carrying redundant information between two files?  True that it's
> no worse than qmp-commands.hx; it would also ensure we aren't regressing
> on quality of user documentation in relation to prior releases.  We
> could do the restore of that file, but if we do, we should fix the bugs
> in pre-conversion qmp-events.txt (a couple events were undocumented,
> there were some grammar errors, all fixed as part of the conversion), as
> well as document events that have been added post-conversion.

No events were added post-conversion, since ACPI_DEVICE_OST first went 
in under the old scheme and Luiz then applied the conversion patch when 
he did the rebase.

We're really close to hard freeze and by extension the release.  Do 
_not_ strive for perfection.  Get something that is mostly okay and is 
an obvious patch.  We'll then have 3 weeks to do documentation patches.

Paolo

  reply	other threads:[~2014-06-26 13:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25  9:30 [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt Michal Privoznik
2014-06-25  9:34 ` Paolo Bonzini
2014-06-25  9:37   ` Michal Privoznik
2014-06-25 13:56 ` Eric Blake
2014-06-25 17:21   ` Markus Armbruster
2014-06-25 19:50   ` Luiz Capitulino
2014-06-25 20:13     ` Eric Blake
2014-06-26 12:46       ` Luiz Capitulino
2014-06-26 13:01         ` Paolo Bonzini
2014-06-26 13:11           ` Eric Blake
2014-06-26 13:14             ` Paolo Bonzini [this message]
2014-06-26 13:17               ` Luiz Capitulino
2014-06-26 13:25                 ` Paolo Bonzini
2014-06-26 13:43                   ` [Qemu-devel] [PATCH] qmp: add qmp-events.txt back Luiz Capitulino
2014-06-26 13:56                     ` Paolo Bonzini
2014-06-26 16:31                     ` Eric Blake
2014-06-26 16:25                   ` [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt Eric Blake
2014-06-26 16:27                     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AC1C99.8070106@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mprivozn@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wenchaoqemu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).