From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X09VE-0003K4-G1 for qemu-devel@nongnu.org; Thu, 26 Jun 2014 09:14:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X09V7-0007Gp-0Z for qemu-devel@nongnu.org; Thu, 26 Jun 2014 09:14:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X09V6-0007Ge-KO for qemu-devel@nongnu.org; Thu, 26 Jun 2014 09:14:04 -0400 Message-ID: <53AC1C99.8070106@redhat.com> Date: Thu, 26 Jun 2014 15:14:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <4b996aea34144d33f2227835dc3d064818ffb7be.1403688576.git.mprivozn@redhat.com> <53AAD523.3000604@redhat.com> <20140625155048.252833c1@redhat.com> <53AB2D71.7050704@redhat.com> <20140626084611.20f771a2@redhat.com> <53AC19C3.10502@redhat.com> <53AC1C13.40308@redhat.com> In-Reply-To: <53AC1C13.40308@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Luiz Capitulino Cc: Michal Privoznik , famz@redhat.com, qemu-devel@nongnu.org, Wenchao Xia Il 26/06/2014 15:11, Eric Blake ha scritto: >> > >> > Can we just revert to the pre-conversion qmp-events.txt file? This is >> > similar to the situation with qmp-commands.hx. > As in, carrying redundant information between two files? True that it's > no worse than qmp-commands.hx; it would also ensure we aren't regressing > on quality of user documentation in relation to prior releases. We > could do the restore of that file, but if we do, we should fix the bugs > in pre-conversion qmp-events.txt (a couple events were undocumented, > there were some grammar errors, all fixed as part of the conversion), as > well as document events that have been added post-conversion. No events were added post-conversion, since ACPI_DEVICE_OST first went in under the old scheme and Luiz then applied the conversion patch when he did the rebase. We're really close to hard freeze and by extension the release. Do _not_ strive for perfection. Get something that is mostly okay and is an obvious patch. We'll then have 3 weeks to do documentation patches. Paolo