From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X0BFj-0006oH-Kl
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:06:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X0BFd-0007nZ-KE
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:06:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52872)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X0BFd-0007nV-BD
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:06:13 -0400
Message-ID: <53AC36DB.8090009@redhat.com>
Date: Thu, 26 Jun 2014 09:06:03 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1403526734-29237-1-git-send-email-cnanakos@grnet.gr>
	<1403526734-29237-2-git-send-email-cnanakos@grnet.gr>
In-Reply-To: <1403526734-29237-2-git-send-email-cnanakos@grnet.gr>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="30KanAvHV8CAe6cXvLDiDiR5OUaONkCSK"
Subject: Re: [Qemu-devel] [PATCH v5 1/4] block: Support Archipelago as a
 QEMU block backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chrysostomos Nanakos <cnanakos@grnet.gr>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--30KanAvHV8CAe6cXvLDiDiR5OUaONkCSK
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 06/23/2014 06:32 AM, Chrysostomos Nanakos wrote:
> VM Image on Archipelago volume is specified like this:
>=20
> file=3Darchipelago:<volumename>[/mport=3D<mapperd_port>[:vport=3D<vlmcd=
_port>][:
> segment=3D<segment_name>]]
>=20
> or
>=20
> file.driver=3Darchipelago,file.volume=3D<volumename>[,file.mport=3D<map=
perd_port>[,
> file.vport=3D<vlmcd_port>][,file.segment=3D<segment_name>]]
>=20

I still plan to review this series in full, but my quick pre-review comme=
nt:

on version 2, Markus suggested that you should separate the patch that
adds QMP structured options (first) from the patch that adds syntactic
sugar
file=3Darchipelago:<volumename>[/mport=3D<mapperd_port>[:vport=3D<vlmcd_p=
ort>]] (second)

https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00269.html

and I stand by his suggestion, although I don't see that split here yet.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--30KanAvHV8CAe6cXvLDiDiR5OUaONkCSK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTrDbbAAoJEKeha0olJ0Nqay4IAJNpAC3MaUhqVGIzn1hzQi2B
3mOHHYeAivx2+IyY9VwgVJOl7BN2TOvypslh94vb0SgM1X7E6WCDLgZ5A6wdRodP
LauCKQ0x2hwDyXG1M5O680XflH+h6PvI4UH5gf7boL6SNQKvGf2qAHQ1VPNUAs/Y
imgW7AvSOQcCXJikC3JDBKnlrv9PjbxkRCk+15G3kRqT8NbpVZpzBSCtRzsLVU05
BFnlS8YwA7NSoBUstE+grhGK13wI/1/YZeqe01+RP1P0MBiqlyG56d98eLI0CRp3
0LIvYcn0zD+++sd9F1PZEuHBLWg+4USfmBwym/PRENXnlYhnzDUl0Sjp55iLZrM=
=7vax
-----END PGP SIGNATURE-----

--30KanAvHV8CAe6cXvLDiDiR5OUaONkCSK--