From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0BIH-00081U-LM for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:09:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0BI8-0000OO-5T for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:08:57 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:57105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0BI7-0000OB-T9 for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:08:48 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Jun 2014 16:08:45 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 49A881B0805F for ; Thu, 26 Jun 2014 16:09:16 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s5QF8h2033554496 for ; Thu, 26 Jun 2014 15:08:43 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s5QF8gkp006027 for ; Thu, 26 Jun 2014 09:08:43 -0600 Message-ID: <53AC3779.1060606@linux.vnet.ibm.com> Date: Thu, 26 Jun 2014 19:08:41 +0400 From: "Eugene \"jno\" Dvurechenski" MIME-Version: 1.0 References: <1403793009-54176-1-git-send-email-jfrei@linux.vnet.ibm.com> <1403793009-54176-4-git-send-email-jfrei@linux.vnet.ibm.com> <53AC2FCE.4020404@suse.de> In-Reply-To: <53AC2FCE.4020404@suse.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JxtHHHmP8Dr3aVeDfs9FkGGEJ4APTJGhw" Subject: Re: [Qemu-devel] [PATCH 03/10] pc-bios/s390-ccw: handle different sector sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Jens Freimann , Christian Borntraeger , Cornelia Huck Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JxtHHHmP8Dr3aVeDfs9FkGGEJ4APTJGhw Content-Type: multipart/mixed; boundary="------------070201080408040901060608" This is a multi-part message in MIME format. --------------070201080408040901060608 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2014 06:35 PM, Alexander Graf wrote: >> - ns_end =3D sec + SECTOR_SIZE; >> + ns_end =3D sec + virtio_get_block_size(); =2E.. >> -#define SECTOR_SIZE 512 >> +#define SECTOR_SIZE 4096 >=20 > Why keep the define at all? Just to use as default value and in storage allocation (and similar static calculations) now. --=20 Best Regards, Eugene "jno" Dvurechenski zLinux (KVM) Development - Software Engineer IBM Russia - Science & Technology Center phone: +7 (495) 660 8940 ext. 1021 --------------070201080408040901060608 Content-Type: text/x-vcard; charset=utf-8; name="jno.vcf" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="jno.vcf" YmVnaW46dmNhcmQNCmZuOkV1Z2VuZSBEdnVyZWNoZW5za2kNCm46RHZ1cmVjaGVuc2tpO0V1 Z2VuZQ0Kb3JnOklCTSBTeXN0ZW1zICYgVGVjaG5vbG9neSBHcm91cDtJQk0gUyZUIENlbnRl ciwgUnVzc2lhDQphZHI6OztPYnJ1Y2hldmEgc3QuLCBibGQuMzAvMSwgRTJWLCBmbG9vciA0 O01vc2Nvdzs7MTE3NDg1O1J1c3NpYQ0KZW1haWw7aW50ZXJuZXQ6am5vQGxpbnV4LnZuZXQu aWJtLmNvbQ0KdGl0bGU6U29mdHdhcmUgRW5naW5lZXINCnRlbDt3b3JrOis3ICg0OTUpIDY2 MCA4OTQwIGV4dC4gMTAyMQ0KdGVsO2NlbGw6KzcgKDkwMykgNzkwLTA3LTQ5DQp4LW1vemls bGEtaHRtbDpGQUxTRQ0KdXJsOmh0dHA6Ly9mc3cuc3UvDQp2ZXJzaW9uOjIuMQ0KZW5kOnZj YXJkDQoNCg== --------------070201080408040901060608-- --JxtHHHmP8Dr3aVeDfs9FkGGEJ4APTJGhw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTrDd5AAoJEBd44R522cduHWYP/21EmGuIFZm4Afzt8Ai4S1U7 8IEtkaBAC91u2ykZr8t3WJtY/Xuduxso4yvyJL+XEDJI30np9rYuEkXN/aDhXqvt FlWEw7qcPMJoivXJ1NAR5r5p+8yZFlKSEYsU2rvWYEBVyZufQsr9oY09j/cxGey+ auN2XuZYls4Ey6+yu6ItupOmxUTykWABxO++IQyjU/46vnCRkBF0KZqlVYl6smHy q9vJ/HVrWlUzqlvnGMmjQS3bBw/bTmFs3jyeEJQrOhc8iQCwgnkh6D/G2+Hg172S is3gT6B8vj0iQiMZXZvFNoLju7mTkVVARLSW1VI+OgmbEG19lXpZ5HRLSoDeR6jh XDGzyDfRs6c9eCmPkZbd3wQPuKFipTdXmuDNoIeA+uWxEVLNzTsBhAh4PM9WNhYw 4ounJgvHZIPfB44ILRR4Y0+OREXcdZ9S/YoPf+HXCcK4mnY7hJVRenDyo3yWxgrk TI1MUxBB9RzTK7KUl/kvXLWgBRIlzlIQEMz38deFQ9Iot21TKx8B8pzxQmnDVxVj /jsLJOkRQvfjD9dwB8i6gq1aAH1++xmYa9L4ym3Rd16npgY6u2tGnUgZ6nWO9bCb sskfS4Z56jkrHs+NybdPu2ngWQF3Q9H3pPWFyW7fQ1GOs5pcRKwFJhYFj1MAs2Mo 8q068a9RTaWKSQuP4RWm =3JNU -----END PGP SIGNATURE----- --JxtHHHmP8Dr3aVeDfs9FkGGEJ4APTJGhw--