From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X0BnU-0006S5-8h
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:41:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X0BnL-0004e9-8J
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:41:12 -0400
Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:50307)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X0BnK-0004e1-RR
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:41:03 -0400
Received: by mail-we0-f171.google.com with SMTP id q58so3834435wes.16
	for <qemu-devel@nongnu.org>; Thu, 26 Jun 2014 08:41:01 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53AC3F09.2070705@redhat.com>
Date: Thu, 26 Jun 2014 17:40:57 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com>	<1403073840-32603-22-git-send-email-pbonzini@redhat.com>
	<87simrd6lu.fsf@blackfin.pond.sub.org>
In-Reply-To: <87simrd6lu.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert
	BLOCK_IO_ERROR and BLOCK_JOB_ERROR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, wenchaoqemu@gmail.com, lcapitulino@redhat.com

Il 26/06/2014 17:37, Markus Armbruster ha scritto:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
>> From: Wenchao Xia <wenchaoqemu@gmail.com>
>>
>> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> This broke tests/qemu-iotests/041.  Apparently, the BLOCK_JOB_ERROR
> event changed from
> 
>     {'timestamp': {'seconds': 1403796871, 'microseconds': 446502},
>      'data': {'device': 'drive0',

-    bdrv_emit_qmp_error_event(job->bs, QEVENT_BLOCK_JOB_ERROR, action, is_read);
+    qapi_event_send_block_job_error(bdrv_get_device_name(bs),

Should have been job->bs.

>               'action': 'ignore',
>               'operation': 'write'},
>      'event': 'BLOCK_JOB_ERROR'}
> 
> to
> 
>     {'timestamp': {'seconds': 1403796674, 'microseconds': 63271},
>      'data': {'device': '',
>               'action': 'report',

I suppose ignore vs. report is just from pasting two different sections?

Paolo

>               'operation': 'write'},
>      'event': 'BLOCK_JOB_ERROR'}
> 
> losing the value of device, which breaks qemu-iotests/041's tests of
> data/device.
> 
> Please fix.
> 
>