From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X0CJz-0000NX-N6
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:14:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X0CJp-0007wz-A4
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:14:47 -0400
Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:61657)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X0CJp-0007wq-3n
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:14:37 -0400
Received: by mail-wg0-f44.google.com with SMTP id x13so3691235wgg.3
	for <qemu-devel@nongnu.org>; Thu, 26 Jun 2014 09:14:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53AC46E6.9020809@redhat.com>
Date: Thu, 26 Jun 2014 18:14:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1403355502-12288-1-git-send-email-pbonzini@redhat.com>	<1403355502-12288-4-git-send-email-pbonzini@redhat.com>	<CAFEAcA8oZnQRDQ1WS-o-2ZK3Kyr8XMm0fCgQqpJwkWiiOU3k2g@mail.gmail.com>	<53AC2B08.8030404@redhat.com>
	<CAFEAcA9VV=uAbpdUuAN1-y71vWf72hA=XR4PiPgfmaW2oms8iA@mail.gmail.com>
In-Reply-To: <CAFEAcA9VV=uAbpdUuAN1-y71vWf72hA=XR4PiPgfmaW2oms8iA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B,
	drop bswap_code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Il 26/06/2014 16:53, Peter Maydell ha scritto:
>>> >> This will break running BE32 binaries with "-cpu any"
>>> >> (which sets all the features we know about, including
>>> >> ARM_FEATURE_V7).
>> >
>> > Yes, this was on purpose.
> I would expect that anybody running BE32 binaries is
> probably running them with -cpu any, since it's the
> default. So breaking them is a bit harsh...
>

Yeah, it is.  I guess I can do

static inline bool arm_sctlr_b(CPUARMState *env)
{
     return
#ifndef TARGET_USER_ONLY
       !arm_feature(env, ARM_FEATURE_V7) &&
#endif
       (env->cp15.c1_sys & SCTLR_B) != 0;
}

instead.  Plus a comment of course.

Paolo