From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] block: Do not prematurely remove "filename"
Date: Thu, 26 Jun 2014 13:46:35 -0600 [thread overview]
Message-ID: <53AC789B.8000807@redhat.com> (raw)
In-Reply-To: <1403809762-4858-2-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On 06/26/2014 01:09 PM, Max Reitz wrote:
> If "filename" is removed from the options QDict before entering
> bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait
> until it has been copied there and remove it from the options only
> afterwards.
>
> This fixes "filename" in the BDS being empty for block drivers which do
> not need the filename because they have parsed it already (e.g. NBD).
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block.c | 24 +++++++++++++++++-------
> 1 file changed, 17 insertions(+), 7 deletions(-)
>
How does this play with Kevin's bdrv_open cleanups?
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg06173.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-26 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 19:09 [Qemu-devel] [PATCH v2 0/2] block: Fix unset "filename" for certain drivers Max Reitz
2014-06-26 19:09 ` [Qemu-devel] [PATCH v2 1/2] block: Do not prematurely remove "filename" Max Reitz
2014-06-26 19:46 ` Eric Blake [this message]
2014-06-26 20:01 ` Max Reitz
2014-06-26 20:06 ` Max Reitz
2014-06-26 19:09 ` [Qemu-devel] [PATCH v2 2/2] iotests: Add test for set "filename" for NBD Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AC789B.8000807@redhat.com \
--to=eblake@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).