From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Fd6-0006bq-L3 for qemu-devel@nongnu.org; Thu, 26 Jun 2014 15:46:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0Fd1-0006aU-Nv for qemu-devel@nongnu.org; Thu, 26 Jun 2014 15:46:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Fd1-0006aB-BR for qemu-devel@nongnu.org; Thu, 26 Jun 2014 15:46:39 -0400 Message-ID: <53AC789B.8000807@redhat.com> Date: Thu, 26 Jun 2014 13:46:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403809762-4858-1-git-send-email-mreitz@redhat.com> <1403809762-4858-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1403809762-4858-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LuokpmQl3dQAhKVCcS82p50gImFkGfNme" Subject: Re: [Qemu-devel] [PATCH v2 1/2] block: Do not prematurely remove "filename" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LuokpmQl3dQAhKVCcS82p50gImFkGfNme Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2014 01:09 PM, Max Reitz wrote: > If "filename" is removed from the options QDict before entering > bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait > until it has been copied there and remove it from the options only > afterwards. >=20 > This fixes "filename" in the BDS being empty for block drivers which do= > not need the filename because they have parsed it already (e.g. NBD). >=20 > Signed-off-by: Max Reitz > --- > block.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) >=20 How does this play with Kevin's bdrv_open cleanups? https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg06173.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LuokpmQl3dQAhKVCcS82p50gImFkGfNme Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTrHibAAoJEKeha0olJ0Nqi9IIAJHNLqAv951xuMWOtdIie4/W b1LZ+xu7EsexS8fYy9a4kjMOcHA9EGY1uaWIpJjRfDec0uJlxX8zVGWajhnLQMnx TeBQhwkvnYtVxWEOuMEde84CNnn+0UuNzXHmCMurENRyb6hzKpLMlBxNgSLDIAwF yqB7XRY86Rn9dVAXmf9Ej/OG5AkJfBgegMDnjino7UYTL4rGrxxyofGLsHdJOiux rwTW6hA3w92v0MMfOC89JrFi09j/aCmVZ0b5+0XU8Mxgv25Sr2GqtrsbvOZxBriv PtxsAmO26lRR6U4TD2raEH/+RglUtIY8fbBeMfRJaw6oDg+UTxBoqzfZyMozYLY= =zJze -----END PGP SIGNATURE----- --LuokpmQl3dQAhKVCcS82p50gImFkGfNme--