From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49479)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1X0Fhb-0008L3-8K
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 15:51:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1X0FhV-000864-9L
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 15:51:23 -0400
Received: from mail-qg0-x235.google.com ([2607:f8b0:400d:c04::235]:61529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1X0FhV-00085w-5B
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 15:51:17 -0400
Received: by mail-qg0-f53.google.com with SMTP id i50so3458355qgf.26
	for <qemu-devel@nongnu.org>; Thu, 26 Jun 2014 12:51:16 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53AC79AF.9030307@twiddle.net>
Date: Thu, 26 Jun 2014 12:51:11 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1403797037-20734-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1403797037-20734-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC UNTESTED] tcg/ppc: Fix support for 64-bit PPC
	MacOSX hosts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, patches@linaro.org

On 06/26/2014 08:37 AM, Peter Maydell wrote:
> +++ b/tcg/ppc/tcg-target.c
> @@ -1716,6 +1716,9 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, bool is_64)
>  # define LINK_AREA_SIZE                (6 * SZR)
>  # define LR_OFFSET                     (1 * SZR)
>  # define TCG_TARGET_CALL_STACK_OFFSET  (LINK_AREA_SIZE + 8 * SZR)
> +#elif defined(TCG_TARGET_CALL_DARWIN)
> +# define LINK_AREA_SIZE                (6 * SZR)
> +# define LR_OFFSET                     (2 * SZR)
>  #elif TCG_TARGET_REG_BITS == 64

Reviewed-by: Richard Henderson <rth@twiddle.net>

It does indeed give the same layout as before for darwin.


r~