From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0G6Z-0003AM-5g for qemu-devel@nongnu.org; Thu, 26 Jun 2014 16:17:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0G6R-0008KG-9z for qemu-devel@nongnu.org; Thu, 26 Jun 2014 16:17:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0G6R-0008KC-0c for qemu-devel@nongnu.org; Thu, 26 Jun 2014 16:17:03 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5QKH2fo026113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 26 Jun 2014 16:17:02 -0400 Message-ID: <53AC7FBA.8050101@redhat.com> Date: Thu, 26 Jun 2014 22:16:58 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1403797803-11984-1-git-send-email-lersek@redhat.com> <53AC4C4F.1050708@redhat.com> In-Reply-To: <53AC4C4F.1050708@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.1 v3 0/2] help libvirt know what's up with qga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org, mprivozn@redhat.com, kraxel@redhat.com, amit.shah@redhat.com, lcapitulino@redhat.com On 06/26/14 18:37, Eric Blake wrote: > On 06/26/2014 09:50 AM, Laszlo Ersek wrote: >> Changes in v3: patch 1 creates the event with a "bool" field called >> "open" in the data portion, instead of introducing a two-valued enum. >> Patch 2 is left intact. Retested. >> >> Laszlo Ersek (2): >> virtio-serial: report frontend connection state via monitor >> char: report frontend open/closed state in 'query-chardev' > > Series: > Reviewed-by: Eric Blake > >> >> qapi-event.json | 14 ++++++++++++++ >> qapi-schema.json | 8 +++++++- >> hw/char/virtio-console.c | 12 +++++++++--- >> monitor.c | 1 + >> qemu-char.c | 1 + >> qmp-commands.hx | 19 ++++++++++++++----- >> 6 files changed, 46 insertions(+), 9 deletions(-) > > Luiz is probably going to revive qmp-events.txt, at which point that > file will need to be patched in a followup patch; I can help with that > process (it's documentation-only, so safe to take even after hard freeze). If it helps, here's two examples in advance (also, note to self): 2014-06-26 15:41:37.895+0000: 1637: debug : qemuMonitorJSONIOProcessLine:172 : QEMU_MONITOR_RECV_EVENT: mon=0x7f2e2400cfd0 event={"timestamp": {"seconds": 1403797297, "microseconds": 895242}, "event": "VSERPORT_CHANGE", "data": {"open": true, "id": "channel0"}} 2014-06-26 15:41:40.878+0000: 1637: debug : qemuMonitorJSONIOProcessLine:172 : QEMU_MONITOR_RECV_EVENT: mon=0x7f2e2400cfd0 event={"timestamp": {"seconds": 1403797300, "microseconds": 878169}, "event": "VSERPORT_CHANGE", "data": {"open": false, "id": "channel0"}} Thanks Laszlo