From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0HcX-0006i3-ER for qemu-devel@nongnu.org; Thu, 26 Jun 2014 17:54:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0HcS-0007SF-DP for qemu-devel@nongnu.org; Thu, 26 Jun 2014 17:54:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0HcS-0007S3-4o for qemu-devel@nongnu.org; Thu, 26 Jun 2014 17:54:12 -0400 Message-ID: <53AC9680.70407@redhat.com> Date: Thu, 26 Jun 2014 15:54:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403818727-11215-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1403818727-11215-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="knNjA9h02xdWoR80nXe8ldMO0qIieCXxM" Subject: Re: [Qemu-devel] [PATCH for 2.1 v3 0/2] block: Fix unset "filename" for certain drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --knNjA9h02xdWoR80nXe8ldMO0qIieCXxM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2014 03:38 PM, Max Reitz wrote: > For some protocol block drivers, the "filename" attribute in their BDSs= > is unset due to bdrv_file_open() removing it from the options QDict > before bdrv_open_common() is able to copy it into the BDS. Fix this by > not removing it until until bdrv_open_common() has indeed copied it. >=20 >=20 > v3: > - Patch 1: Rebased onto Kevin's block branch, especially his series > "bdrv_open() cleanups, part 1" [Eric] Series: Reviewed-by: Eric Blake > Max Reitz (2): > block: Do not prematurely remove "filename" > iotests: Add test for set "filename" for NBD >=20 > block.c | 35 ++++++++++++++++++---- > tests/qemu-iotests/097 | 72 ++++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/097.out | 13 +++++++++ > tests/qemu-iotests/group | 1 + > 4 files changed, 115 insertions(+), 6 deletions(-) > create mode 100755 tests/qemu-iotests/097 > create mode 100644 tests/qemu-iotests/097.out >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --knNjA9h02xdWoR80nXe8ldMO0qIieCXxM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTrJaAAAoJEKeha0olJ0NqvtkH/iBHQj+HykQpuF4yfstAzY9K UF5wWjWXskQcQOuXYL4vSAKlhEDVyW1mZBR3yX7RkGuQNqzHvhel1Ic5/VQkdK6i KfGMatv8k214/qAd7LLqHgk7Gj/NXWbOkjv7ZvHdkSuZ/dCmYaGqCQWwX5Cj4u71 k96POXKFuty+/RUBizk36z3nEypytAzzVDZT93yChkKrIZHK1POy4d9GJC22MnH5 lSWzpANuRT2QMtFpXKXSoK4oN7BgCoZud9zHu7cz+5qTDqAix4z2LAGYdwzAdGVS ck0NrfpGqF9RGWPqRJWmkDWR+Xsb4k68sdwH3JX8/L90zYGVlU1p2TJwcMz9qzg= =+xPr -----END PGP SIGNATURE----- --knNjA9h02xdWoR80nXe8ldMO0qIieCXxM--