From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0SRK-0003ON-0e for qemu-devel@nongnu.org; Fri, 27 Jun 2014 05:27:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0SRA-00026o-Uj for qemu-devel@nongnu.org; Fri, 27 Jun 2014 05:27:25 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:48934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0SRA-00026j-L2 for qemu-devel@nongnu.org; Fri, 27 Jun 2014 05:27:16 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 27 Jun 2014 10:27:15 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id C43D317D8047 for ; Fri, 27 Jun 2014 10:28:41 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s5R9RDWM31129846 for ; Fri, 27 Jun 2014 09:27:13 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s5R9RC5N016716 for ; Fri, 27 Jun 2014 03:27:13 -0600 Message-ID: <53AD38F0.9010204@de.ibm.com> Date: Fri, 27 Jun 2014 11:27:12 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1403793009-54176-1-git-send-email-jfrei@linux.vnet.ibm.com> <53AC3147.1090209@suse.de> <53AD22EF.6050507@de.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Cornelia Huck , Jens Freimann , "qemu-devel@nongnu.org" On 27/06/14 11:05, Alexander Graf wrote: > > >> Am 27.06.2014 um 09:53 schrieb Christian Borntraeger : >> >>> On 26/06/14 16:42, Alexander Graf wrote: >>> >>>> On 26.06.14 16:29, Jens Freimann wrote: >>>> Conny, Alex, Christian, >>>> >>>> here are some fixes for the s390-ccw bios. It's a mixture of >>>> additional features (DASD IPL support for different formats) >>>> and cleanups. >>> >>> From a quick glimpse it looks quite clean and straight forward, but I'd like to make sure we get rid completely of the static sector size assumption. >> >> Should be. I guess s/SECTOR_SIZE/MAX_SECTOR_SIZE/g would be ok for you then? > > I'm not 100% convinced that we're safe on all users of SECTOR_SIZE. So please make sure to replace the occasions manually and audit every single one. Yes, a mindless sed, would also replace VIRTIO_SECTOR_SIZE with VIRTIO_MAX_SECTOR_SIZE. Fortunately there are only 3 place in bootmap.c. Should be simple enough to review. > > Alex > >>> >>> Also, are we guaranteed that virtio always uses 512 byte block size? Or was that just an internal API thing? >> >> The virtio-blk API always talks in 512 byte sectors, no matter the block size. >> >> Overall this is a nice improvement of the boot code - if possible I would like to see that in 2.1. >> >> Conny, can you carry that in your tree (with s/SECTOR_SIZE/MAX_SECTOR_SIZE/g)? >> >> Acked-by: Christian Borntraeger >> >> for the series. >> >> >> Christian >> >