From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0eIf-0003DN-GG for qemu-devel@nongnu.org; Fri, 27 Jun 2014 18:07:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0eIZ-0001TT-Bm for qemu-devel@nongnu.org; Fri, 27 Jun 2014 18:07:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0eIZ-0001TH-1c for qemu-devel@nongnu.org; Fri, 27 Jun 2014 18:07:11 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5RM7AHi002146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 27 Jun 2014 18:07:10 -0400 Message-ID: <53ADEB0A.4010504@redhat.com> Date: Sat, 28 Jun 2014 00:07:06 +0200 From: Max Reitz MIME-Version: 1.0 References: <1402167080-20316-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1402167080-20316-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 00/14] qemu-img: Implement commit like QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 07.06.2014 20:51, Max Reitz wrote: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. For > the "commit" command, this is relatively easy, so implement it first > (in the hope that indeed others will follow). > > As qemu-img does not have access to QMP (due to QMP being intertwined > with basically everything in qemu), we cannot directly use QMP, but at > least use the functions the corresponding QMP commands are using (which > would be "block-commit", in this case). > > > With Stefan's pull request for his dataplane series now out, I thought > this a good opportunity to send a rebase of this series. Ping; Hu Tao will need "minimal_blob_size()" from patch 3 for the next iteration of his "qemu-img: add preallocation=full" series. Sending an own patch just for that function seems infeasible, as it is a static function which would be unused in the meantime (which throws a compiler warning and an error thanks to -Werror). Using __attribute__((unused)) just for this seems like a hack; especially considering that all patches of this series have been reviewed and it should therefore be ready to merge. In case there are some objections because you want to test it more, it would be fine to merge the first three patches (which suffice for the preallocation series and should only introduce unused codepaths) now and the rest later on. Max