From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33650)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X1aL9-0002Oe-0b
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 08:05:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X1aL2-0008GR-ON
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 08:05:42 -0400
Message-ID: <53B1528E.8060407@suse.de>
Date: Mon, 30 Jun 2014 14:05:34 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1404117329-7899-1-git-send-email-nikunj@linux.vnet.ibm.com>
	<31B6319B-D5B1-4FA6-829A-679B692AF436@suse.de>
	<87oaxawxy7.fsf@abhimanyu.in.ibm.com>
In-Reply-To: <87oaxawxy7.fsf@abhimanyu.in.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5] ppc: spapr-rtas - implement os-term
	rtas call
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@au1.ibm.com>, "aik@ozlabs.ru" <aik@ozlabs.ru>, Tyrel Datwyler <turtle.in.the.kernel@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, Anton Blanchard <anton@samba.org>


On 30.06.14 11:25, Nikunj A Dadhania wrote:
> Alexander Graf <agraf@suse.de> writes:
>
>>> Am 30.06.2014 um 10:35 schrieb Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>:
>>>
>>> +static void rtas_ibm_os_term(PowerPCCPU *cpu,
>>> +                            sPAPREnvironment *spapr,
>>> +                            uint32_t token, uint32_t nargs,
>>> +                            target_ulong args,
>>> +                            uint32_t nret, target_ulong rets)
>>> +{
>>> +    target_ulong ret = 0;
>>> +
>>> +    qapi_event_send_guest_panicked(GUEST_PANIC_ACTION_PAUSE, &error_abort);
>> The guest doesn't pause.
> I see the event reaching libvirt and a dump taken and the guest
> restarts.
>
>> Since the guest will call os-term in a loop, this will also flood the
>> event listener with lots and lots of panic messages.
> 	do {
> 		status = rtas_call(rtas_token("ibm,os-term"), 1, 1, NULL,
> 				   __pa(rtas_os_term_buf));
> 	} while (rtas_busy_delay(status));
>
> So when status from the rtas call is success, the loop should exit.
>
> Am I missing something?

No, I think you're right. I'll queue it for 2.2.


Alex