From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1aP5-0004Ig-0Q for qemu-devel@nongnu.org; Mon, 30 Jun 2014 08:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1aOy-0001ZD-T4 for qemu-devel@nongnu.org; Mon, 30 Jun 2014 08:09:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50826 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1aOy-0001Z5-GI for qemu-devel@nongnu.org; Mon, 30 Jun 2014 08:09:40 -0400 Message-ID: <53B15383.40603@suse.de> Date: Mon, 30 Jun 2014 14:09:39 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1404066076-32859-1-git-send-email-reza.jelveh@tuhh.de> In-Reply-To: <1404066076-32859-1-git-send-email-reza.jelveh@tuhh.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: reza.jelveh@gmail.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, jsnow@redhat.com On 29.06.14 20:21, reza.jelveh@gmail.com wrote: > This requires a custom ovmf image with sata controller for testing [0] > > [0]: http://reza.jelveh.me/assets/OVMF.fd.bz2 > I guess this is supposed to be a cover letter? A few rules for cover letters: 1) Cover letters only make sense for patch sets. This is a single patch, so you don't need one 2) Because they come with patch sets and you number patch sets, cover letters are [PATCH 0/n]. 3) Usually cover letters contain git statistics. Try git format-patch --cover-letter. It will give you a nice template. The usual way to add the comment you have here to a patch you're trying to submit it is to put volatile information (things that shouldn't end up in the git log) behind a "---" line in the commit message. Everything after that line gets ignored by git when the patch gets applied. Alex