From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1anI-0003Q7-4B for qemu-devel@nongnu.org; Mon, 30 Jun 2014 08:34:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1an9-0001Km-GO for qemu-devel@nongnu.org; Mon, 30 Jun 2014 08:34:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1an9-0001Kc-8x for qemu-devel@nongnu.org; Mon, 30 Jun 2014 08:34:39 -0400 Message-ID: <53B1595C.1020202@redhat.com> Date: Mon, 30 Jun 2014 14:34:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403974776-23966-1-git-send-email-peter.maydell@linaro.org> <53B15381.7060308@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Stefan Hajnoczi Il 30/06/2014 14:13, Peter Maydell ha scritto: >> > config-devices.mak is not reflected in any C header file. Apart from this, >> > >> > Reviewed-by: Paolo Bonzini > Do you mean "...and therefore should not be listed on the > RHS of this dependency" ? It need not be listed; it doesn't hurt to leave it in, so whatever the submitter wants to do is fine. :) Paolo