From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Patch Tracking <patches@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind
Date: Mon, 30 Jun 2014 14:36:17 +0200 [thread overview]
Message-ID: <53B159C1.7020909@redhat.com> (raw)
In-Reply-To: <CAFEAcA8TkS9XDud14XRvhsypAviQ1i0BvU=FajC_0Am5SENSqw@mail.gmail.com>
Il 30/06/2014 14:33, Peter Maydell ha scritto:
>> >
>> > It's unnecessary. tcp_chr_accept calls tcp_chr_add_client, which takes care
>> > of that. But it doesn't hurt either.
> I think the tcp_chr_accept->tcp_chr_add_client->set_nonblock
> is marking the new fd returned from accept() as nonblocking.
> The call in qemu_chr_open_socket_fd() is marking the listening
> fd as nonblocking. So those are different things...
Uh, you're right. I think the call in qemu_chr_open_socket_fd simply
means "after the currently connected disconnects, subsequent accepts
will be done via select(), so the socket can now be marked as
non-blocking". The qemu-char logic is right then.
Paolo
prev parent reply other threads:[~2014-06-30 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 20:55 [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind Peter Maydell
2014-06-23 12:49 ` Markus Armbruster
2014-06-23 13:05 ` Peter Maydell
2014-06-30 10:23 ` Gerd Hoffmann
2014-06-30 10:33 ` Peter Maydell
2014-06-30 10:57 ` Gerd Hoffmann
2014-06-30 11:31 ` Peter Maydell
2014-06-30 12:29 ` Paolo Bonzini
2014-06-30 12:33 ` Peter Maydell
2014-06-30 12:36 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B159C1.7020909@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).