From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, wenchaoqemu@gmail.com, stefanha@redhat.com,
Benoit Canet <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH for 2.1] qapi: Change back sector-count to sectors-count in quorum QAPI events.
Date: Mon, 30 Jun 2014 09:58:05 -0600 [thread overview]
Message-ID: <53B1890D.80808@redhat.com> (raw)
In-Reply-To: <1404140741-16849-1-git-send-email-benoit.canet@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
On 06/30/2014 09:05 AM, Benoît Canet wrote:
> fe069d9d had aligned code and documentation while dropping the s from the
> actual JSON output. Fix that.
Uggh. I missed that in my review (I was obviously less careful in the
second half of the series than in the first half). It's annoying that
we have an inconsistency, but back-compat demands that we preserve the
spelling difference between the parameters. This needs to go in to
avoid a regression.
>
> This also fix test/qemu-iotest/081 since the missing s was causing a permutation.
>
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
> docs/qmp/qmp-events.txt | 26 +++++++++++++-------------
> qapi/event.json | 8 ++++----
> 2 files changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-30 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 15:05 [Qemu-devel] [PATCH] qapi: Change back sector-count to sectors-count in quorum QAPI events Benoît Canet
2014-06-30 15:58 ` Eric Blake [this message]
2014-07-01 7:26 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B1890D.80808@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wenchaoqemu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).