From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1dyB-0001dm-4r for qemu-devel@nongnu.org; Mon, 30 Jun 2014 11:58:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1dy5-0002mb-Tt for qemu-devel@nongnu.org; Mon, 30 Jun 2014 11:58:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1dy5-0002mM-LK for qemu-devel@nongnu.org; Mon, 30 Jun 2014 11:58:09 -0400 Message-ID: <53B1890D.80808@redhat.com> Date: Mon, 30 Jun 2014 09:58:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404140741-16849-1-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1404140741-16849-1-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RvVfk3BuAvJ75X2rPPh4RoXOhUj4HtS0J" Subject: Re: [Qemu-devel] [PATCH for 2.1] qapi: Change back sector-count to sectors-count in quorum QAPI events. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, wenchaoqemu@gmail.com, stefanha@redhat.com, Benoit Canet This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RvVfk3BuAvJ75X2rPPh4RoXOhUj4HtS0J Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/30/2014 09:05 AM, Beno=C3=AEt Canet wrote: > fe069d9d had aligned code and documentation while dropping the s from t= he > actual JSON output. Fix that. Uggh. I missed that in my review (I was obviously less careful in the second half of the series than in the first half). It's annoying that we have an inconsistency, but back-compat demands that we preserve the spelling difference between the parameters. This needs to go in to avoid a regression. >=20 > This also fix test/qemu-iotest/081 since the missing s was causing a pe= rmutation. >=20 > Signed-off-by: Benoit Canet > --- > docs/qmp/qmp-events.txt | 26 +++++++++++++------------- > qapi/event.json | 8 ++++---- > 2 files changed, 17 insertions(+), 17 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RvVfk3BuAvJ75X2rPPh4RoXOhUj4HtS0J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTsYkNAAoJEKeha0olJ0Nq4roH/3N28IAUbLINKz5zKN05YpOZ ay1bIuTIK2VupxvImQRujHq9jVNRtRJmD5F4kJaiS4GagGBNfgPCHArorSogtV8b 8VzjsSD7iQtfRspPVK6fll8Jpq+01koOKZ/5N4z/AfV/NXJIlJFf/3yn9pZ/f3r7 Ye2t1kOzPgfwS6k1eQhbsTeMUw/GaU6jo3QAFDdDEKm06Cnn4r2bRgILqIJBrow7 CEUsRv9fojmoUYJ5EomNKUZz++25qAW+qw2bWSnHituOQ/HdybU+o8UCp0xOc5Mz yLbt8+o2eXj8I4SHwwHWeI5yen7u3m6niw+x1itFdcxgaFMZgLNlTfL84I7O3Ww= =y2oc -----END PGP SIGNATURE----- --RvVfk3BuAvJ75X2rPPh4RoXOhUj4HtS0J--