From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1tP9-0005zM-Jn for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:27:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1tP2-0005fh-DT for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:27:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1tP2-0005fZ-50 for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:27:00 -0400 Message-ID: <53B270CE.3050800@redhat.com> Date: Tue, 01 Jul 2014 10:26:54 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1404179460-29303-1-git-send-email-aik@ozlabs.ru> <53B24A29.1030607@ozlabs.ru> <53B25A97.2070407@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH fix for 2.1] makefile: Fix tools compile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alexey Kardashevskiy , QEMU Developers , Alex Graf Il 01/07/2014 10:19, Peter Maydell ha scritto: >> > I think something like "double x; int f(void) {return isnan(sin(x));}" >> > should be bullet proof. > This is a compile_prog test, though -- the compiler could spot > that x and f are both unused, since it has the entire program > in hand. My suggestion would be: > > int main(int argc, char **argv) { return isnan(sin((double)argc)); } Ok, v2 of the pull request is on the way. Paolo